-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating eslintrc #40
Merged
robertandremitchell
merged 12 commits into
main
from
rob/2783-fix-errors-generated-by-eslintrcjson
Oct 22, 2024
Merged
Updating eslintrc #40
robertandremitchell
merged 12 commits into
main
from
rob/2783-fix-errors-generated-by-eslintrcjson
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertandremitchell
requested review from
bamader,
m-goggins,
DanPaseltiner and
fzhao99
October 22, 2024 13:21
fzhao99
reviewed
Oct 22, 2024
fzhao99
reviewed
Oct 22, 2024
lgtm! will give an approval once Brandon's PR goes in since we're locking main |
fzhao99
approved these changes
Oct 22, 2024
robertandremitchell
deleted the
rob/2783-fix-errors-generated-by-eslintrcjson
branch
October 22, 2024 19:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Adds back commented out code and fixing any code that is still flagged as problematic.
This was a little trickier to clean up existing code to be conformant, the biggest one is probably type guards, which I will concede is probably not the best handled, but that seemed to be what was recommended to clean out the
any
s in that situation.Related Issue
Fixes #2783
Acceptance Criteria
Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)
For frontend PR’s - include a description (including anything that’s out of scope) for what you want the designers to review
Additional Information
Anything else the review team should know?
Checklist