Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating eslintrc #40

Merged

Conversation

robertandremitchell
Copy link
Collaborator

@robertandremitchell robertandremitchell commented Oct 21, 2024

PULL REQUEST

Summary

Adds back commented out code and fixing any code that is still flagged as problematic.

This was a little trickier to clean up existing code to be conformant, the biggest one is probably type guards, which I will concede is probably not the best handled, but that seemed to be what was recommended to clean out the anys in that situation.

Related Issue

Fixes #2783

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

For frontend PR’s - include a description (including anything that’s out of scope) for what you want the designers to review

  • ex: “Check out the whitespace on the page, as well as the dropdowns in the form. Here is the corresponding Figma link. You can ignore everything else. Also, the button at the bottom doesn’t work now”

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@robertandremitchell robertandremitchell linked an issue Oct 21, 2024 that may be closed by this pull request
@fzhao99
Copy link
Collaborator

fzhao99 commented Oct 22, 2024

lgtm! will give an approval once Brandon's PR goes in since we're locking main

@robertandremitchell robertandremitchell merged commit 09795b4 into main Oct 22, 2024
4 checks passed
@robertandremitchell robertandremitchell deleted the rob/2783-fix-errors-generated-by-eslintrcjson branch October 22, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix errors generated by .eslintrc.json
2 participants