Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors generated by .eslintrc.json #2783

Closed
robertandremitchell opened this issue Oct 17, 2024 · 0 comments · Fixed by CDCgov/dibbs-query-connector#40
Closed

Fix errors generated by .eslintrc.json #2783

robertandremitchell opened this issue Oct 17, 2024 · 0 comments · Fixed by CDCgov/dibbs-query-connector#40
Labels

Comments

@robertandremitchell
Copy link
Collaborator

robertandremitchell commented Oct 17, 2024

File should look like this:

{
  "parser": "@typescript-eslint/parser",
  "plugins": [
    "@typescript-eslint",
    "unused-imports",
    "jsdoc"
  ],
  "extends": [
    "plugin:@next/next/recommended",
    "plugin:jsdoc/recommended-typescript-error",
    "prettier"
  ],
  "env": {
    "es6": true
  },
  "parserOptions": {
    "ecmaVersion": 12,
    "sourceType": "module",
    "allowImportExportEverywhere": true
  },
  "rules": {
    "no-unused-vars": "off",
    "unused-imports/no-unused-imports": "error",
    "unused-imports/no-unused-vars": [
      "warn",
      {
        "vars": "all",
        "varsIgnorePattern": "^_",
        "args": "after-used",
        "argsIgnorePattern": "^_"
      }
    ],
    "jsdoc/check-tag-names": "off",
    "jsdoc/require-jsdoc": [
      "error",
      {
        "require": {
          "ArrowFunctionExpression": true
        },
        "publicOnly": true
      }
    ],
    "@typescript-eslint/no-explicit-any": "error"
  },
  "overrides": [
    {
      "files": [
        "*.test*",
        "**/tests/**/*"
      ],
      "rules": {
        "jsdoc/require-jsdoc": "off"
      }
    }
  ]
}

however, the line "@typescript-eslint/no-explicit-any": "error" generates a number of errors, which can be seen here: https://github.com/CDCgov/dibbs-query-connector/actions/runs/11385977810/job/31677081608?pr=20

Most of these appear to be the same type of error, so ideally can be handled in one PR to update, unless we feel this rule is too stringent for what we actually need.

@robertandremitchell robertandremitchell changed the title Fix .eslintrc.json errors Fix errors generated by .eslintrc.json Oct 17, 2024
@robertandremitchell robertandremitchell linked a pull request Oct 21, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant