Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spare_score to work for python 3.8 up to python 3.12 #22

Merged
merged 25 commits into from
Aug 14, 2024

Conversation

spirosmaggioros
Copy link
Member

Now the package is updated for newer versions of python as well. Users can build spare and download it for python 3.8 up to 3.12. I added 2 workflows to run with python 3.12 seperately. This will not affect NiChart Workflows.

@spirosmaggioros spirosmaggioros linked an issue Aug 14, 2024 that may be closed by this pull request
@spirosmaggioros
Copy link
Member Author

spirosmaggioros commented Aug 14, 2024

Looks like we have a silly macos dependency bug(ONLY for the workflow, locally its working), will fix it now

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 78.33724% with 185 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1869887). Learn more about missing BASE report.

Files Patch % Lines
spare_scores/spare.py 66.66% 61 Missing ⚠️
spare_scores/data_prep.py 62.50% 39 Missing ⚠️
spare_scores/mlp_torch.py 75.93% 32 Missing ⚠️
spare_scores/mlp.py 64.78% 25 Missing ⚠️
spare_scores/svm.py 75.24% 25 Missing ⚠️
spare_scores/classes.py 93.54% 2 Missing ⚠️
spare_scores/util.py 97.72% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage        ?   81.15%           
=======================================
  Files           ?       11           
  Lines           ?     1385           
  Branches        ?        0           
=======================================
  Hits            ?     1124           
  Misses          ?      261           
  Partials        ?        0           
Files Coverage Δ
spare_scores/__init__.py 100.00% <100.00%> (ø)
test_data_prep.py 100.00% <ø> (ø)
tests/unit/test_spare_scores.py 100.00% <100.00%> (ø)
tests/unit/test_util.py 100.00% <100.00%> (ø)
spare_scores/util.py 93.50% <97.72%> (ø)
spare_scores/classes.py 92.53% <93.54%> (ø)
spare_scores/mlp.py 70.64% <64.78%> (ø)
spare_scores/svm.py 78.69% <75.24%> (ø)
spare_scores/mlp_torch.py 75.00% <75.93%> (ø)
spare_scores/data_prep.py 65.60% <62.50%> (ø)
... and 1 more

@AlexanderGetka-cbica AlexanderGetka-cbica merged commit 6629add into CBICA:main Aug 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update spare package to work with all python versions up to 3.12
3 participants