Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2406 Add lastVisit field and set it when user logs in #2527

Merged
merged 13 commits into from
Oct 27, 2023
Merged

#2406 Add lastVisit field and set it when user logs in #2527

merged 13 commits into from
Oct 27, 2023

Conversation

naXa777
Copy link
Collaborator

@naXa777 naXa777 commented Oct 19, 2023 •
edited by ElenaSpb
Loading

Closes #2406 "Add lastVisit field and set it when user logs in"

Changes description:

  • I pulled PR with unfinished work 2406: add last visit field and set it when user logs in #2444
  • I exposed new lastVisit field in UserWithAnalyticsResponse returned by GET /users?withAnalytics=true API
  • The registration date is used as "Last Visit" date in API response, if last visit date is unknown.
  • Code refactoring.
  • Integration with admin UI.

@naXa777 naXa777 requested a review from ElenaSpb as a code owner October 19, 2023 21:31
@naXa777 naXa777 mentioned this pull request Oct 19, 2023
Closed
@ElenaSpb ElenaSpb self-assigned this Oct 20, 2023
@ElenaSpb
Copy link
Contributor

could you please join our dev chat
https://t.me/+R-6ThlxgP5QyZmMy

@ElenaSpb
Copy link
Contributor

ElenaSpb commented Oct 24, 2023 •
edited
Loading

also

  1. from task we have
    "current value from Last Visit move to field lastStudyActivity"
    do you want to implement it too?

  2. I think it would be logically to set lastVisit in case null - the registration date. it can not be null

@naXa777
Copy link
Collaborator Author

naXa777 commented Oct 24, 2023

I think it would be logically to set lastVisit in case null - the registration date. it can not be null

Done.

@naXa777
Copy link
Collaborator Author

naXa777 commented Oct 24, 2023 •
edited
Loading

"current value from Last Visit move to field lastStudyActivity"
do you want to implement it too?

yes, but I don't see "Last Visit" field anywhere in code. There was no Last Visit field before, or maybe it was removed recently, IDK. @ElenaSpb, please clarify this requirement.

UPD: yes, I see lastDone field. Let me implement the change.

@naXa777
Copy link
Collaborator Author

naXa777 commented Oct 24, 2023

some checks have failed. and I suspect that they are broken, cause it's not related to the changes in PR #2527.

I kindly ask to merge this PR and fix the failing GitHub actions separately:

@naXa777 naXa777 requested a review from ElenaSpb October 24, 2023 19:17
@ElenaSpb ElenaSpb requested review from lifeart and Mikleprog October 27, 2023 10:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ElenaSpb ElenaSpb merged commit 3112171 into Brain-up:master Oct 27, 2023
6 of 11 checks passed
@ElenaSpb
Copy link
Contributor

Thank you for contribution to our project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaSpb ElenaSpb ElenaSpb approved these changes

@lifeart lifeart lifeart approved these changes

@Mikleprog Mikleprog Awaiting requested review from Mikleprog

Assignees

@ElenaSpb ElenaSpb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] Add new field LastVisit field in https://brainup.fun/admin/users response
4 participants
@naXa777 @ElenaSpb @lifeart @chackomathew