Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] Add new field LastVisit field in https://brainup.fun/admin/users response #2406

Closed
ElenaSpb opened this issue Dec 1, 2022 · 5 comments · Fixed by #2527 · May be fixed by #2444
Closed

[BE] Add new field LastVisit field in https://brainup.fun/admin/users response #2406

ElenaSpb opened this issue Dec 1, 2022 · 5 comments · Fixed by #2527 · May be fixed by #2444
Assignees
@naXa777 @chackomathew
Labels
backend

Comments

@ElenaSpb
Copy link
Contributor

ElenaSpb commented Dec 1, 2022 •
edited
Loading

[BE] AddLast visit field in https://brainup.fun/admin/users response that will be about last visit to our site.
not about last done exercises as it is now. current value from Last Visit move to field Last study activity

image
@ElenaSpb ElenaSpb added bug Something isn't working backend labels Dec 1, 2022
@ElenaSpb ElenaSpb changed the title [BE] Fix Last visit field in https://brainup.fun/admin/users response [BE] Add new field LastVisit field in https://brainup.fun/admin/users response Dec 3, 2022
@ElenaSpb ElenaSpb removed the bug Something isn't working label Dec 3, 2022
@chackomathew chackomathew self-assigned this Jan 17, 2023
@chackomathew chackomathew mentioned this issue Jan 18, 2023
Draft
@chackomathew chackomathew linked a pull request Jan 18, 2023 that will close this issue
2406: add last visit field and set it when user logs in #2444
Draft
@chackomathew
Copy link
Collaborator

@ElenaSpb I'm planning to capture the Last visit in FirebaseTokenAuthenticationFilter.kt after authentication. So the last visit is updated each time request for a user is received.

Do you see any issues with this approach or another better solution?

@naXa777
Copy link
Collaborator

naXa777 commented Oct 19, 2023

May I continue from where @chackomathew left off and complete the task?

@lifeart
Copy link
Collaborator

lifeart commented Oct 19, 2023

Hi @naXa777 sure, go on!

naXa777 added a commit to naXa777/brn that referenced this issue Oct 19, 2023
@naXa777
Brain-up#2406 set lastVisit null by default; do not assume that las…
4e061bd 
…t visit time was right now
naXa777 added a commit to naXa777/brn that referenced this issue Oct 19, 2023
@naXa777
Brain-up#2406 expose lastVisit field in UserAccountDto
2b27a7f
@naXa777 naXa777 mentioned this issue Oct 19, 2023
Merged
@naXa777
Copy link
Collaborator

naXa777 commented Oct 19, 2023

I opened new PR #2527 with a solution (back-end part). Please review.

I don't understand this part of the task:

not about last done exercises as it is now. current value from Last Visit move to field Last study activity

There was no Last Visit field before, or maybe it was removed recently, IDK. @ElenaSpb, please clarify.

naXa777 added a commit to naXa777/brn that referenced this issue Oct 20, 2023
@naXa777
Brain-up#2406 update lastVisit time for current user
64b21d0
naXa777 added a commit to naXa777/brn that referenced this issue Oct 24, 2023
@naXa777
Brain-up#2406 code refactoring
62cabf2
naXa777 added a commit to naXa777/brn that referenced this issue Oct 24, 2023
@naXa777
Brain-up#2406 rename migration script
d453e0d
naXa777 added a commit to naXa777/brn that referenced this issue Oct 24, 2023
@naXa777
Brain-up#2406 set lastVisit as the registration date in case if it'…
d428f58 
…s unknown
naXa777 added a commit to naXa777/brn that referenced this issue Oct 24, 2023
@naXa777
Brain-up#2406 fix errors in tests
a3a04f0
naXa777 added a commit to naXa777/brn that referenced this issue Oct 24, 2023
@naXa777
Brain-up#2406 move current value from 'Last visit' to 'Last study act…
af8481f 
…ivity' field
ElenaSpb added a commit that referenced this issue Oct 27, 2023
@naXa777 @chackomathew @ElenaSpb
#2406 Add lastVisit field and set it when user logs in (#2527)
3112171 
* 2406: add last visit field and set it when user logs in

* #2406 set `lastVisit` null by default; do not assume that last visit time was right now

* #2406 expose `lastVisit` field in `UserAccountDto`

* #2406 update lastVisit time for current user
* #2406 rename migration script

* #2406 set `lastVisit` as the registration date in case if it's unknown

* #2406 fix errors in tests

* #2406 move current value from 'Last visit' to 'Last study activity' field

---------

Co-authored-by: Chacko Mathew <[email protected]>
Co-authored-by: Elena Moshnikova <[email protected]>
@ElenaSpb
Copy link
Contributor Author

Thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naXa777 naXa777

@chackomathew chackomathew

Labels
backend
Projects
None yet
Milestone
No milestone
4 participants
@lifeart @naXa777 @chackomathew @ElenaSpb