Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internals of Style Cartoon and Style Ribbon nodes #603

Merged
merged 18 commits into from
Sep 12, 2024

Conversation

BradyAJohnston
Copy link
Owner

Everything internally is now using Rotations for interpolation so it more smoothly interpolates between some of the more twisted helices and beta sheets. Sheets also use extrusion to create their arrows which fixes shading issue with the arrow heads.

  • initial cleanup of cartoon nodes, use rotation internally
  • more tweaking and overhaul
  • mostly finished cleaning up cartoon with rotations
  • cleanup
  • more improvements and cleanup
  • more tinkering
  • more cleanup
  • tweaks with ribbon creation for cylinders
  • almost done!
  • mostly finalised new cartoon
  • cleanup ribbon
  • final cleanup
  • finalised
  • update tests

@BradyAJohnston BradyAJohnston merged commit e7390fa into main Sep 12, 2024
5 checks passed
@BradyAJohnston BradyAJohnston deleted the cleanup-cartoon-nodes branch September 12, 2024 09:21
@BradyAJohnston BradyAJohnston linked an issue Sep 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Alpha-helix ribbons
1 participant