Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Alpha-helix ribbons #382

Closed
BradyAJohnston opened this issue Dec 15, 2023 · 0 comments · Fixed by #603
Closed

Fix Alpha-helix ribbons #382

BradyAJohnston opened this issue Dec 15, 2023 · 0 comments · Fixed by #603
Labels
bug Something isn't working

Comments

@BradyAJohnston
Copy link
Owner

BradyAJohnston commented Dec 15, 2023 •
edited
Loading

Some AH ribbons are a bit mangled, due to the current interpolation of rotations. This should be fixable by doing 'lofting' around the rotation plane of the helix, rather than the current linear interpolation of the rotations.

EDIT:

This issue can track the overall reworking of cartoon internals. With the 'curves to points' node and the new setting custom normal node in 4.1, the internals of these nodes can be greatly simplified.

Will include #236 in this issue to track more potential designs and shapes for the helices.
@BradyAJohnston BradyAJohnston added the bug Something isn't working label Dec 15, 2023
@BradyAJohnston BradyAJohnston mentioned this issue Jan 9, 2024
Closed
@BradyAJohnston BradyAJohnston linked a pull request Sep 12, 2024 that will close this issue
Refactor internals of Style Cartoon and Style Ribbon nodes #603
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor internals of Style Cartoon and Style Ribbon nodes BradyAJohnston/MolecularNodes
1 participant
@BradyAJohnston