Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #4

Merged
merged 10 commits into from
Jul 28, 2022
Merged

Various fixes #4

merged 10 commits into from
Jul 28, 2022

Conversation

mgeplf
Copy link
Collaborator

@mgeplf mgeplf commented Jul 13, 2022

No description provided.

drodarie added 2 commits May 5, 2022 17:38
Split mandatory ccfv2 fibers and cell containing regions combination from ccfv3 / ccfv2 annotation combination
Add normalization and cell overlapping of Nissl and ISH dataset to match Erö's pipeline.
Fix glia cell density placement, prevent negative densities.
Add purely inhibitory regions for Erö's method to match model from 2019.
atlas_densities/densities/cell_density.py Show resolved Hide resolved
atlas_densities/densities/glia_densities.py Outdated Show resolved Hide resolved
atlas_densities/densities/glia_densities.py Show resolved Hide resolved
atlas_densities/densities/glia_densities.py Show resolved Hide resolved
atlas_densities/densities/glia_densities.py Outdated Show resolved Hide resolved
atlas_densities/densities/inhibitory_neuron_density.py Outdated Show resolved Hide resolved
drodarie and others added 4 commits July 13, 2022 16:10
Convert glia subtype densities to float64.
Fix masks for cerebellar cortex, molecular and cortex L1 and related test.
Add condition for denominator in normalize_intensity.
Fix tests related to get_glia_input_data: forced outside intensity to be low so that the intensity of the fake datasets is not null after thresholding.
Fix test_compute_inhibitory_neuron_density, it now requires a real RegionMap.
drodarie and others added 2 commits July 27, 2022 15:45
Separated the ccfv2 combination from the ccfv2-ccfv3 annotation combination.
Added default config files to run the pipeline in atlas_densities/app/data/.
@mgeplf mgeplf requested a review from drodarie July 28, 2022 07:26
@mgeplf
Copy link
Collaborator Author

mgeplf commented Jul 28, 2022

@drodarie: I noticed there is now atlas_densities/app/data/markers/realigned_slices_cccfv2.json and atlas_densities/app/data/markers/realigned_slices_bbp.json, can you update the README.rst in atlas_densities/app/data/markers/, and also link the correct one in atlas_densities/app/data/fitting/fit_average_densities_config.yaml

drodarie added 2 commits July 28, 2022 13:36
Fix filenames in yaml config files.
The file was moved from to the markers folder.
@mgeplf mgeplf merged commit c4d7948 into main Jul 28, 2022
@mgeplf mgeplf deleted the various_fixes branch July 28, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants