Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double check cell subtype distribution implementations #8

Closed
mgeplf opened this issue Jul 27, 2022 · 2 comments
Closed

double check cell subtype distribution implementations #8

mgeplf opened this issue Jul 27, 2022 · 2 comments
Assignees

Comments

@mgeplf
Copy link
Collaborator

mgeplf commented Jul 27, 2022

It was mentioned here that:

I will propose a fix in my next commit and double check every over cell subtype distribution implementations.
@drodarie
Copy link
Collaborator

I double checked the implementations for cell subtype density placement, and they actually produce correct results.
I got confused because the implementation in atlas-densities and my previous one are different.The difference is that the old one was also used to place the cells while the new one only focus on computing celltype densities.
For the purpose of atlas-densities, this is sufficient, so we can close this issue.

@mgeplf
Copy link
Collaborator Author

mgeplf commented Sep 16, 2022

Ok, sounds good - thanks for looking.

@mgeplf mgeplf closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants