-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of data exchange mechanisms between robot and supervisor using Serial Webots drivers #138
Conversation
…isor and APP with the use of SerialMuxprot
… line is detected for a specified time.
…robot in the supervisor.
… the state machine in the Ready State and the position and orientation of the robot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not review content but structure and integrity of other apps.
- All files under the path
lib/APPReinforcementLearning/
andlib/HALReinforcementLearning/
should be contained in asrc
folder. Check the structure in other apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of C++ part haltet for restructuring and fixing previous existing review comments
doc/architecture/uml/LogicalView/ReinforcementLearning/Application.plantuml
Outdated
Show resolved
Hide resolved
doc/architecture/uml/LogicalView/ReinforcementLearning/Application.plantuml
Outdated
Show resolved
Hide resolved
Please add your application to the README.md in the "The Applications" section |
…nto feature/RL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @hoeftjch should make the final lreview and approval before merging.
Edit: found some more stuff
…oda-style in all files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me now. Architecture changes in RL_Supervisor will likely be necessary for next updates.
Main functions:
Initialization of the serial communication:
Initialize the serial driver in the robot and in the supervisor.
Sensor data transmission:
Sensor data is sent from the robot to the supervisor, and the supervisor receives the data.
Motor control:
The Supervisor sends the specified motor control data to the robot.
The robot receives the motor control data and updates the motor speeds accordingly.
Reset Logic for Loss of Line Tracking:
Monitor sensor data for loss of line tracking.
Initialize the robot's position and orientation after a fixed number of steps without line detection.
Reset the robot to the standby state without recalibrating the motors and sensors.
Training or driving mode:
The mode (training or driving) is selected by pressing a button.
If no button is pressed within a specified time, the robot will default to the training mode.
Training or driving will not begin until the start/stop line is crossed.