Feature/ros2 tcp #185
Merged
Feature/ros2 tcp #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to show if UDP or TCP protocol is used.
Solution is instable and highly timing sensitive. Operation is working for a few twist messages but ping breaks down unexpectingly.
BlueAndi
reviewed
Oct 29, 2024
BlueAndi
reviewed
Oct 29, 2024
BlueAndi
reviewed
Oct 29, 2024
A state machine was needed to read the record from fragmented socket stream reads.
Add config.json change instead (default port)
+ TCP support documented
BlueAndi
requested changes
Oct 30, 2024
BlueAndi
requested changes
Oct 31, 2024
gabryelreyes
reviewed
Nov 3, 2024
review feedback
BlueAndi
approved these changes
Nov 5, 2024
gabryelreyes
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.