fix: typecheck some tests in modules/bitgo/

DEVELOPERS.md

@@ -205,7 +205,7 @@ Here is a template to help get started:</br>
     "outDir": "./dist",
     "rootDir": "."
   },
-  "include": ["src/**/*", "package.json"],
+  "include": ["src/**/*", "test/**/*", "package.json"],
   "references": [
     {
       "path": "../sdk-core"

modules/bitgo/package.json

@@ -26,9 +26,9 @@
     "webpack-dev": "cross-env NODE_ENV=development webpack",
     "webpack-prod": "NODE_OPTIONS=--max-old-space-size=4096 cross-env NODE_ENV=production webpack",
     "test": "npm run coverage",
-    "unit-test": "mocha 'test/v2/unit/**/*.ts' 'test/unit/**/*.ts'",
+    "unit-test": "mocha 'test/legacy/v2/unit/**/*.ts' 'test/legacy/unit/**/*.ts' 'test/utxo/**/*.ts'",
     "coverage": "nyc -- npm run unit-test",
-    "integration-test": "nyc -- mocha \"test/v2/integration/**/*.ts\"",
+    "integration-test": "nyc -- mocha \"test/legacy/v2/integration/**/*.ts\"",
     "browser-test": "karma start karma.conf.js",
     "lint": "eslint --quiet .",
     "audit": "if [ \"$(npm --version | cut -d. -f1)\" -ge \"6\" ]; then npm audit; else echo \"npm >= 6 required to perform audit. skipping...\"; fi",

modules/bitgo/test/legacy/README.md

@@ -0,0 +1,7 @@
+# `test/legacy`
+
+These tests were historically excluded from typecheck, so some of the tests here are broken.
+
+Consider moving them outside of `test/legacy` and fixing them.
+
+Avoid adding new tests here.

modules/bitgo/test/ecdh.ts → modules/bitgo/test/legacy/ecdh.ts

@@ -9,7 +9,7 @@ import * as utxolib from '@bitgo/utxo-lib';
 import { getSharedSecret, signMessageWithDerivedEcdhKey, verifyEcdhSignature } from '@bitgo/sdk-core';
 import { TestBitGo } from '@bitgo/sdk-test';
 import * as assert from 'assert';
-import { BitGo } from '../src/bitgo';
+import { BitGo } from '../../src/bitgo';
 
 describe('ECDH utils', () => {
   function getKey(seed: string) {

modules/bitgo/test/integration/blockchain.ts → modules/bitgo/test/legacy/integration/blockchain.ts

@@ -9,7 +9,7 @@
 import { strict as assert } from 'assert';
 import 'should';
 
-const BitGoJS = require('../../src/index');
+const BitGoJS = require('../../../src');
 const TestBitGo = require('../lib/test_bitgo');
 
 const TEST_ADDRESS1 = '2N4Xz4itCdKKUREiySS7oBzoXUKnuxP4nRD';

modules/bitgo/test/integration/index.html → modules/bitgo/test/legacy/integration/index.html

@@ -12,7 +12,7 @@
     <script>
       mocha.setup('bdd');
     </script>
-    <script src="../browser/tests.js"></script>
+    <script src="../legacy/browser/tests.js"></script>
     <script>
       mocha.run();
     </script>

modules/bitgo/test/integration/markets.ts → modules/bitgo/test/legacy/integration/markets.ts

@@ -6,7 +6,7 @@
 
 import { strict as assert } from 'assert';
 import 'should';
-const BitGoJS = require('../../src/index');
+const BitGoJS = require('../../../src');
 
 describe('Market', function () {
   let bitgo;

modules/bitgo/test/integration/pendingapproval.ts → modules/bitgo/test/legacy/integration/pendingapproval.ts

@@ -9,7 +9,7 @@ import { strict as assert } from 'assert';
 import 'should';
 import * as utxolib from '@bitgo/utxo-lib';
 
-const BitGoJS = require('../../src/index');
+const BitGoJS = require('../../../src');
 const TestBitGo = require('../lib/test_bitgo');
 const TestUtil = require('./testutil');
 

modules/bitgo/test/integration/travelRule.ts → modules/bitgo/test/legacy/integration/travelRule.ts

@@ -10,7 +10,7 @@ import 'should';
 import * as _ from 'lodash';
 import { getSharedSecret } from '../../src/ecdh';
 
-const BitGoJS = require('../../src/index');
+const BitGoJS = require('../../../src');
 const bitcoin = BitGoJS.bitcoin;
 const sjcl = require('@bitgo/sjcl');
 const TestBitGo = require('../lib/test_bitgo');

modules/bitgo/test/integration/wallet.ts → modules/bitgo/test/legacy/integration/wallet.ts

@@ -13,7 +13,7 @@ import * as utxolib from '@bitgo/utxo-lib';
 
 const Q = require('q');
 
-const BitGoJS = require('../../src/index');
+const BitGoJS = require('../../../src');
 import { TestBitGo } from '../lib/test_bitgo';
 const TransactionBuilder = require('../../src/transactionBuilder');
 const crypto = require('crypto');

modules/bitgo/test/integration/webhooks.ts → modules/bitgo/test/legacy/integration/webhooks.ts

@@ -10,7 +10,7 @@ import { strict as assert } from 'assert';
 import 'should';
 import * as _ from 'lodash';
 
-const BitGoJS = require('../../src/index');
+const BitGoJS = require('../../../src');
 const TestBitGo = require('../lib/test_bitgo');
 
 describe('Webhooks', function () {

modules/bitgo/test/unit/bitgo.ts → modules/bitgo/test/legacy/unit/bitgo.ts

@@ -10,11 +10,11 @@ import assert = require('assert');
 import { common, generateGPGKeyPair } from '@bitgo/sdk-core';
 import { bip32, ECPair } from '@bitgo/utxo-lib';
 import * as _ from 'lodash';
-import * as BitGoJS from '../../src/index';
+import * as BitGoJS from '../../../src';
 const rp = require('request-promise');
 
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../src/bitgo';
+import { BitGo } from '../../../src/bitgo';
 
 nock.disableNetConnect();
 

modules/bitgo/test/unit/keychains.ts → modules/bitgo/test/legacy/unit/keychains.ts

@@ -9,7 +9,7 @@ import 'should';
 import { common } from '@bitgo/sdk-core';
 
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../src/bitgo';
+import { BitGo } from '../../../src/bitgo';
 
 describe('Keychains', function v2keychains() {
   describe('Update Password', function updatePassword() {

modules/bitgo/test/unit/legacyBitcoin.ts → modules/bitgo/test/legacy/unit/legacyBitcoin.ts

@@ -1,5 +1,5 @@
 import 'should';
-import * as BitGoJS from '../../src';
+import * as BitGoJS from '../../../src';
 
 describe('legacyBitcoin', function () {
   it('toBase58Check, fromBase58Check', function () {

modules/bitgo/test/unit/local.ts → modules/bitgo/test/legacy/unit/local.ts

@@ -5,9 +5,9 @@
 //
 
 import 'should';
-import * as BitGoJS from '../../src';
+import * as BitGoJS from '../../../src';
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../src/bitgo';
+import { BitGo } from '../../../src/bitgo';
 
 describe('Constructor', function () {
   it('arguments', function () {

modules/bitgo/test/v2/integration/bitgo.ts → modules/bitgo/test/legacy/v2/integration/bitgo.ts

@@ -8,7 +8,7 @@
 
 import { strict as assert } from 'assert';
 
-import * as BitGoJS from '../../../src/index';
+import * as BitGoJS from '../../../../src';
 import { TestBitGo } from '../../lib/test_bitgo';
 
 const TestUtil = require('../../integration/testutil');

modules/bitgo/test/v2/integration/coins/xlm.ts → modules/bitgo/test/legacy/v2/integration/coins/xlm.ts

@@ -1,7 +1,7 @@
 import 'should';
 
 import * as Bluebird from 'bluebird';
-import { BaseCoin } from '../../../../src/v2';
+import { BaseCoin } from '../../../../../src/v2';
 const co = Bluebird.coroutine;
 
 import { TestBitGo } from '../../../lib/test_bitgo';

modules/bitgo/test/v2/integration/markets.ts → modules/bitgo/test/legacy/v2/integration/markets.ts

@@ -6,7 +6,7 @@
 
 import 'should';
 import { coroutine as co } from 'bluebird';
-const BitGoJS = require('../../../src/index');
+const BitGoJS = require('../../../../src');
 
 describe('Market', function () {
   // We start with supported coins, then add 't' to the front of each to get testnet coins

modules/bitgo/test/v2/unit/accountConsolidations.ts → modules/bitgo/test/legacy/v2/unit/accountConsolidations.ts

@@ -11,8 +11,9 @@ import * as nock from 'nock';
 import { common, Wallet } from '@bitgo/sdk-core';
 
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../src/bitgo';
-const algoFixtures = require('../../../../sdk-coin-algo/test/fixtures/algo');
+import { BitGo } from '../../../../src/bitgo';
+// eslint-disable-next-line import/no-internal-modules
+const algoFixtures = require('@bitgo/sdk-coin-algo/dist/test/fixtures/algo');
 
 nock.disableNetConnect();
 

modules/bitgo/test/v2/unit/auth.ts → modules/bitgo/test/legacy/v2/unit/auth.ts

@@ -2,7 +2,7 @@ import * as nock from 'nock';
 import 'should';
 import * as sinon from 'sinon';
 
-import { BitGo } from '../../../src';
+import { BitGo } from '../../../../src';
 
 describe('Auth', () => {
   describe('Auth V3', () => {

modules/bitgo/test/v2/unit/baseCoin.ts → modules/bitgo/test/legacy/v2/unit/baseCoin.ts

@@ -6,7 +6,7 @@ import 'should';
 import * as nock from 'nock';
 
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../src/bitgo';
+import { BitGo } from '../../../../src/bitgo';
 import { Erc20Token } from '@bitgo/sdk-coin-eth';
 import { StellarToken } from '@bitgo/sdk-coin-xlm';
 

modules/bitgo/test/v2/unit/coins/abstractEthCoin.ts → modules/bitgo/test/legacy/v2/unit/coins/abstractEthCoin.ts

@@ -6,7 +6,7 @@ import * as _ from 'lodash';
 import * as should from 'should';
 import { bip32 } from '@bitgo/utxo-lib';
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../../src/bitgo';
+import { BitGo } from '../../../../../src/bitgo';
 import { getBuilder, Eth } from '@bitgo/account-lib';
 import * as ethAbi from 'ethereumjs-abi';
 import * as ethUtil from 'ethereumjs-util';

modules/bitgo/test/v2/unit/coins/abstractUtxoCoin.ts → modules/bitgo/test/legacy/v2/unit/coins/abstractUtxoCoin.ts

@@ -3,7 +3,7 @@ import * as should from 'should';
 import * as sinon from 'sinon';
 import { UnexpectedAddressError, VerificationOptions } from '@bitgo/sdk-core';
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../../src/bitgo';
+import { BitGo } from '../../../../../src/bitgo';
 import {
   AbstractUtxoCoin,
   AbstractUtxoCoinWallet,

modules/bitgo/test/v2/unit/coins/ofc.ts → modules/bitgo/test/legacy/v2/unit/coins/ofc.ts

@@ -1,7 +1,7 @@
 import 'should';
 
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../../src/bitgo';
+import { BitGo } from '../../../../../src/bitgo';
 
 describe('OFC:', function () {
   let bitgo;

modules/bitgo/test/v2/unit/coins/ofcToken.ts → modules/bitgo/test/legacy/v2/unit/coins/ofcToken.ts

@@ -1,6 +1,6 @@
 import 'should';
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../../src/bitgo';
+import { BitGo } from '../../../../../src/bitgo';
 
 const PRECISION_2 = '100';
 const PRECISION_6 = '1000000';

modules/bitgo/test/v2/unit/coins/stellarToken.ts → modules/bitgo/test/legacy/v2/unit/coins/stellarToken.ts

@@ -1,7 +1,7 @@
 import 'should';
 
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../../src/bitgo';
+import { BitGo } from '../../../../../src/bitgo';
 
 describe('Stellar Token:', function () {
   let bitgo;

modules/bitgo/test/v2/unit/coins/susd.ts → modules/bitgo/test/legacy/v2/unit/coins/susd.ts

@@ -1,7 +1,7 @@
 import 'should';
 
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../../src/bitgo';
+import { BitGo } from '../../../../../src/bitgo';
 
 describe('SUSD:', function () {
   let bitgo;

modules/bitgo/test/v2/unit/coins/token.ts → modules/bitgo/test/legacy/v2/unit/coins/token.ts

@@ -2,7 +2,7 @@ import 'should';
 import { BaseCoin } from '@bitgo/sdk-core';
 
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../../src/bitgo';
+import { BitGo } from '../../../../../src/bitgo';
 
 describe('Virtual Token:', function () {
   let bitgo;

modules/bitgo/test/v2/unit/coins/tsusd.ts → modules/bitgo/test/legacy/v2/unit/coins/tsusd.ts

@@ -1,7 +1,7 @@
 import 'should';
 
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../../src/bitgo';
+import { BitGo } from '../../../../../src/bitgo';
 
 describe('TSUSD:', function () {
   let bitgo;

modules/bitgo/test/v2/unit/custodialLightning.ts → modules/bitgo/test/legacy/v2/unit/custodialLightning.ts

@@ -1,6 +1,6 @@
 import { TestBitGo } from '@bitgo/sdk-test';
 import { common, Wallet, encodeLnurl, parseLightningInvoice } from '@bitgo/sdk-core';
-import { BitGo } from '../../../src/bitgo';
+import { BitGo } from '../../../../src/bitgo';
 import * as nock from 'nock';
 import * as assert from 'assert';
 import * as sinon from 'sinon';

modules/bitgo/test/v2/unit/enterprise.ts → modules/bitgo/test/legacy/v2/unit/enterprise.ts

@@ -7,7 +7,7 @@ import * as sinon from 'sinon';
 import { common, ECDSAUtils, Enterprise } from '@bitgo/sdk-core';
 
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../src/bitgo';
+import { BitGo } from '../../../../src/bitgo';
 import { mockChallengeA } from './internal/tssUtils/mocks/ecdsaNtilde';
 import { bip32 } from '@bitgo/utxo-lib';
 

modules/bitgo/test/v2/unit/environments.ts → modules/bitgo/test/legacy/v2/unit/environments.ts

@@ -1,5 +1,5 @@
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../src/bitgo';
+import { BitGo } from '../../../../src/bitgo';
 import { AliasEnvironments } from '@bitgo/sdk-core';
 
 describe('Environments', () => {

modules/bitgo/test/v2/unit/internal/blsUtils.ts → modules/bitgo/test/legacy/v2/unit/internal/blsUtils.ts

@@ -4,7 +4,7 @@ import * as should from 'should';
 import * as openpgp from 'openpgp';
 
 import { TestableBG, TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../../src';
+import { BitGo } from '../../../../../src';
 import { BlsUtils, common, IBlsKeyPair, Keychain } from '@bitgo/sdk-core';
 import assert = require('assert');
 import { Eth2 } from '@bitgo/sdk-coin-eth2';

modules/bitgo/test/v2/unit/internal/tssUtils/bitgoMpcGpgPubKeys.ts → modules/bitgo/test/legacy/v2/unit/internal/tssUtils/bitgoMpcGpgPubKeys.ts

@@ -9,7 +9,7 @@ import {
 } from '@bitgo/sdk-core';
 import { TestBitGo } from '@bitgo/sdk-test';
 
-import { BitGo } from '../../../../../src';
+import { BitGo } from '../../../../../../src';
 import * as openpgp from 'openpgp';
 import nock = require('nock');
 import assert = require('assert');

modules/bitgo/test/v2/unit/internal/tssUtils/ecdsa.ts → modules/bitgo/test/legacy/v2/unit/internal/tssUtils/ecdsa.ts

@@ -11,7 +11,7 @@ import {
   TestableBG,
   TestBitGo,
 } from '@bitgo/sdk-test';
-import { BitGo, createSharedDataProof, TssUtils, RequestType } from '../../../../../src';
+import { BitGo, createSharedDataProof, TssUtils, RequestType } from '../../../../../../src';
 import {
   BackupGpgKey,
   BackupKeyShare,

modules/bitgo/test/v2/unit/internal/tssUtils/ecdsaMPCv2/createKeychains.ts → modules/bitgo/test/legacy/v2/unit/internal/tssUtils/ecdsaMPCv2/createKeychains.ts

@@ -25,7 +25,7 @@ import {
   WalletTypeEnum,
 } from '@bitgo/public-types';
 import { NonEmptyString } from 'io-ts-types';
-import { BitGo, BitgoGPGPublicKey } from '../../../../../../src';
+import { BitGo, BitgoGPGPublicKey } from '../../../../../../../src';
 import * as v1Fixtures from './fixtures/mpcv1KeyShares';
 
 describe('TSS Ecdsa MPCv2 Utils:', async function () {

modules/bitgo/test/v2/unit/internal/tssUtils/ecdsaMPCv2/signTxRequest.ts → modules/bitgo/test/legacy/v2/unit/internal/tssUtils/ecdsaMPCv2/signTxRequest.ts

@@ -24,7 +24,7 @@ import {
 import * as openpgp from 'openpgp';
 import * as nock from 'nock';
 import { TestableBG, TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../../../../src';
+import { BitGo } from '../../../../../../../src';
 const createKeccakHash = require('keccak');
 
 interface SignatureShareApiBody {

modules/bitgo/test/v2/unit/internal/tssUtils/eddsa.ts → modules/bitgo/test/legacy/v2/unit/internal/tssUtils/eddsa.ts

@@ -6,7 +6,7 @@ import * as should from 'should';
 import * as sinon from 'sinon';
 
 import { TestableBG, TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../../../src/bitgo';
+import { BitGo } from '../../../../../../src/bitgo';
 import {
   common,
   Keychain,

modules/bitgo/test/v2/unit/keychains.ts → modules/bitgo/test/legacy/v2/unit/keychains.ts

@@ -20,7 +20,7 @@ import {
   OvcShare,
 } from '@bitgo/sdk-core';
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../src/bitgo';
+import { BitGo } from '../../../../src/bitgo';
 
 describe('V2 Keychains', function () {
   let bitgo;

modules/bitgo/test/v2/unit/lightning/lightningWallets.ts → modules/bitgo/test/legacy/v2/unit/lightning/lightningWallets.ts

@@ -3,7 +3,7 @@ import { TestBitGo } from '@bitgo/sdk-test';
 import * as nock from 'nock';
 import { BaseCoin, getLightningAuthKeychains, getLightningKeychain } from '@bitgo/sdk-core';
 
-import { BitGo, common, GenerateLightningWalletOptions, Wallet, Wallets } from '../../../../src';
+import { BitGo, common, GenerateLightningWalletOptions, Wallet, Wallets } from '../../../../../src';
 
 describe('Lightning wallets', function () {
   const coinName = 'tlnbtc';

modules/bitgo/test/v2/unit/mmi.ts → modules/bitgo/test/legacy/v2/unit/mmi.ts

@@ -1,10 +1,10 @@
 import { TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../src/bitgo';
+import { BitGo } from '../../../../src/bitgo';
 
 import * as nock from 'nock';
 import { bip32 } from '@bitgo/utxo-lib';
 import { common, TransactionType } from '@bitgo/sdk-core';
-import { AvaxC as AvaxCAccountLib, getBuilder } from '../../../../account-lib';
+import { AvaxC as AvaxCAccountLib, getBuilder } from '@bitgo/account-lib';
 
 nock.enableNetConnect();
 

modules/bitgo/test/v2/unit/pendingApproval.ts → modules/bitgo/test/legacy/v2/unit/pendingApproval.ts

@@ -5,7 +5,7 @@ import 'should';
 import * as nock from 'nock';
 import * as sinon from 'sinon';
 import { TestableBG, TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../src';
+import { BitGo } from '../../../../src';
 
 import {
   BaseCoin,

modules/bitgo/test/v2/unit/recovery.ts → modules/bitgo/test/legacy/v2/unit/recovery.ts

@@ -2,7 +2,7 @@ import * as should from 'should';
 import * as nock from 'nock';
 
 import { mockSerializedChallengeWithProofs, TestBitGo } from '@bitgo/sdk-test';
-import { BitGo } from '../../../src';
+import { BitGo } from '../../../../src';
 import { krsProviders } from '@bitgo/sdk-core';
 import { EcdsaRangeProof, EcdsaTypes } from '@bitgo/sdk-lib-mpc';
 import { TransactionFactory } from '@ethereumjs/tx';