fix: typecheck some tests in modules/bitgo/
#5187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoAllmendinger
force-pushed
the
BTC-1450.fix-bitgo-tests
branch
from
76f08d9
to
55cc28e
Compare
There was a problem hiding this comment.
this file was pretty pointless - I believe it provided IDE hints which were ignored
For unclear reasons, the `test/` folder is often excluded from `tsconfig.json`, which leads to tests that do not compile correctly. This commit quarantines these existing tests in `modules/bitgo` to `test/legacy`, allowing a fresh start in `test/` with type-checked tests. Issue: BTC-1450
We should in fact build the tests. They will not be packaged due to the corresponding lines in `.npmignore`. Issue: BTC-1450
The utxo tests do in fact typecheck, so we can move them out of `test/legacy/` Issue: BTC-1450
OttoAllmendinger
force-pushed
the
BTC-1450.fix-bitgo-tests
branch
from
55cc28e
to
21d818d
Compare
OttoAllmendinger
changed the title
modules/bitgo/
OttoAllmendinger
changed the title
modules/bitgo/modules/bitgo/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move failing tests
refactor(bitgo): move broken tests to test/legacy
For unclear reasons, the
test/folder is often excluded fromtsconfig.json,which leads to tests that do not compile correctly.
This commit quarantines these existing tests in
modules/bitgototest/legacy, allowing a fresh start intest/with type-checked tests.Issue: BTC-1450
feat(bitgo): add README to test/legacy
Issue: BTC-1450
fix(bitgo): include test files in default
tsconfig.jsonWe should in fact build the tests.
They will not be packaged due to the corresponding lines in
.npmignore.Issue: BTC-1450
refactor(bitgo): move utxo tests to test/utxo
The utxo tests do in fact typecheck, so we can move them out of
test/legacy/Issue: BTC-1450