Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios: fix exporting files (CSV exports, log export, notes export) #2939

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Oct 9, 2024

  1. ios: fix exporting files (CSV exports, log export, notes export)

    Similar to Android, we set `ExportsDir()` to `""` and let
    the backend environment `getSaveFilename()` construct the full path.
    
    Mobile handling of the dirs/files is a big hack and works on implicit
    assumptions, e.g. that `getSaveFilename()` is always called with
    `filepath.Join(exportsDir, filename)`, which is only the filename on
    mobile as `ExportsDir()` returns `""`. This should be cleaned up, but
    for now iOS is made to behave like Android in this regard.
    
    We use a temp directory for these files, so the files will be cleaned
    up automatically after a while.
    benma committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    cfd893b View commit details
    Browse the repository at this point in the history