ios: fix exporting files (CSV exports, log export, notes export) #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to Android, we set `ExportsDir()` to `""` and let the backend environment `getSaveFilename()` construct the full path. Mobile handling of the dirs/files is a big hack and works on implicit assumptions, e.g. that `getSaveFilename()` is always called with `filepath.Join(exportsDir, filename)`, which is only the filename on mobile as `ExportsDir()` returns `""`. This should be cleaned up, but for now iOS is made to behave like Android in this regard. We use a temp directory for these files, so the files will be cleaned up automatically after a while.
|
Ping @Beerosagos in case you missed it |
Beerosagos
reviewed
Oct 10, 2024
| class GoEnvironment: NSObject, MobileserverGoEnvironmentInterfaceProtocol, UIDocumentInteractionControllerDelegate { | ||
| func getSaveFilename(_ fileName: String?) -> String { | ||
| let tempDirectory = URL(fileURLWithPath: NSTemporaryDirectory(), isDirectory: true) | ||
| let fileURL = tempDirectory.appendingPathComponent(fileName!) |
There was a problem hiding this comment.
I think we need a guard for fileName, like the one used in systemOpen for the urlString
| return scene.windows.first(where: { $0.isKeyWindow })?.rootViewController | ||
| } | ||
|
|
||
| func systemOpen(_ urlString: String?) throws { |
There was a problem hiding this comment.
The function doesn't throw any exception, I think you can remove the throws keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Android, we set
ExportsDir()to""and let the backend environmentgetSaveFilename()construct the full path.Mobile handling of the dirs/files is a big hack and works on implicit assumptions, e.g. that
getSaveFilename()is always called withfilepath.Join(exportsDir, filename), which is only the filename on mobile asExportsDir()returns"". This should be cleaned up, but for now iOS is made to behave like Android in this regard.