Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 19 commits into
base: feedback
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Auto detect text files and perform LF normalization
* text=auto
Binary file added Portfolio website-Report.docx
Binary file not shown.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[![Review Assignment Due Date](https://classroom.github.com/assets/deadline-readme-button-24ddc0f5d75046c5622901739e7c5dd533143b0c8e959d652212380cedb1ea36.svg)](https://classroom.github.com/a/59P2FRZS)
Binary file added accessibility-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added cta-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added easy-to-use-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image manipulation/fairy-in-bulb-02.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image manipulation/hive.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image manipulation/horse-02.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image manipulation/ice.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image manipulation/temple.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added image manipulation/women-hair.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/KFC_cover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Upaj_website_cover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/accessibility-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/biogas_cover.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/doctor_cover.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/easy-to-use-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/ledger_cover.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/portfolio-image.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/retaler_cover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/user-friendly-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
51 changes: 51 additions & 0 deletions portfolio_website.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The homepage file should generally be named index.html so that it is automatically picked up by browsers looking at the URL for the website. If you go here, it doesn't exist, but usually this link should work if you have an index.html file.

https://birkbeck2.github.io/web-development-website-project-ikaur02/

You have to go here instead, which is not intuitive:

https://birkbeck2.github.io/web-development-website-project-ikaur02/portfolio_website.html

Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
<!doctype html>
<html lang="en">

<head>
<link rel="stylesheet" href="style_homepage.css">
<meta charset="utf-8">
<title>Ishmeet</title>
</head>

<body>
<div class="header">
<div class="my-name">Ishmeet Kaur</div>
<div class="header-menu">
<nav><!--Navigation bar-->
<ul>
<li><a href="portfolio_website.html">Home</a></li>
<li><a href="portfolio_website_services.html">Services</a></li>
<li><a href="portfolio_website_projects.html">Projects</a></li>
<li><a href="portfolio_website_contact.html">Contact</a></li>
</ul>
</nav>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good

</div>
</div>

<div class="flex_container_me"><!--Introductory section-->
<div class="flex_container_me_01"><img src="images/portfolio-image.png" alt="Ishmeet Kaur image"></div>
<div class="flex_container_me_02"><p>Hey. I am Ishmeet Kaur! I am passionate about creating useful user experiences for making people's lives more fulfilling.</p> </div>
</div>

<div class="flex_container_work"><!--Section showcasing my projects-->
<div class="flex_container_work_01">
<div class="work_01_first_div">
<p>I do experiments & write it down called as Research projects!</p></div>
<div class="work_01_second_div"><img src="images/KFC_cover.png" alt="KFC project cover image"></div>
<div class="work_01_second_div"><img src="images/Upaj_website_cover.png" alt="Upaj website cover image"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for using alt text

</div>
</div>

<div class="flex_container_work_02">
<button>View more</button></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that this is a semantic button element, but it doesn't do anything. What should happen when the user clicks this? The interaction design is not clear to me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user will be directed to projects page and able to view all the projects


<footer>
<div class="flex-container_footer"><!--Footer-->
<div class="flex-container_footer_first_div">
<p>Wanna talk?</p></div>
<div class="flex-container_footer_second_div">
Reach me out at [email protected]</div>
</div>
</footer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are called "flex container" but there are no flex display rules applied. Generally the CSS names should be easy to read to get a sense of what is happening in the code, but this does not give the right impression.

Decent basic use of semantic HTML for the footer.

</body>
</html>
67 changes: 67 additions & 0 deletions portfolio_website_contact.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
<!doctype html>
<html lang="en">

<head>
<link rel="stylesheet" href="style_homepage.css">
<meta charset="utf-8">
<title>Ishmeet_Contact</title>
</head>

<body>
<div class="header">
<div class="my-name">Ishmeet Kaur</div>
<div class="header-menu">
<nav>
<ul>
<li><a href="portfolio_website.html">Home</a></li>
<li><a href="portfolio_website_services.html">Services</a></li>
<li><a href="portfolio_website_projects.html">Projects</a></li>
<li><a href="portfolio_website_contact.html">Contact</a></li>
</ul>
</nav>
</div>
</div>

<div class="container"><!--Contact form-->
<p>Reach out to me. I would love to connect with you for your queries!</p>
<div class="contact-box">
<div class="contact-left">
<form method="post" action="save-contact-details.html">
<div class="input-row">
<div class="input-group"><!--Write full name-->
<label>Full Name</label>
<input type="text" id="fullname" name="fullname" placeholder="John Williams">
</div>
<div class="input-group"><!--Enter mobile number-->
<label>Phone</label>
<input type="text" id="phonenumber" name="phonenumber" placeholder="+1 412 520 3231">
</div>
</div>

<div class="input-row"><!--Enter email id-->
<div class="input-group">
<label>Your mail id</label>
<input type="email" id="email" name="e-mail" placeholder="[email protected]">
</div>

<div class="input-group"><!--Choose gender-->
<label>Gender</label>

<select id="gender" name="gender">
<option value="Male">Male</option>
<option value="Female">Female</option>
<option value="Bisexual">Bisexual</option>
<option value="Heterosexual">Heterosexual</option>
</select>
</div>
</div>
<label>Type your message here</label><!--Write message/give feedback-->
<textarea id="subject" name="subject" placeholder="Your Message Here" rows="5"></textarea>

<button type="submit">Send</button>
</form>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good organization of rows and input groups. Nice use of select, although gender is an odd option for a contact form.

The labels are not properly connected semantically to their corresponding inputs, for accessibility.

The source you named for this doesn't quite show me how you adapted this, especially around organizing inputs and groups for CSS layout purposes. There should have been a comment explaining that more.

</div>
</div>
</div>
</body>
</html>
54 changes: 54 additions & 0 deletions portfolio_website_projects.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
<!doctype html>
<html lang="en">

<head>
<link rel="stylesheet" href="style_homepage.css">
<meta charset="utf-8">
<title>Ishmeet-Projects</title>
</head>

<body>
<div class="header">
<div class="my-name">Ishmeet Kaur</div>
<div class="header-menu">
<nav>
<ul>
<li><a href="portfolio_website.html">Home</a></li>
<li><a href="portfolio_website_services.html">Services</a></li>
<li><a href="portfolio_website_projects.html">Projects</a></li>
<li><a href="portfolio_website_contact.html">Contact</a></li>
</ul>
</nav>
</div>
</div>

<div class="flex_container_project"><!--Parent container showcasing all the projects-->
<div class="flex_container_project_01"><!--Sub-container 01-->
<div class="project_01_first_div">
<p>I do experiments & write it down called as Research projects!Click below to see my projects</p></div>
<div class="project_01_second_div"><a href="//www.behance.net/gallery/181784665/Revamp-KFC-UAE-App"><img src="images/KFC_cover.png" alt="KFC project cover image"></a></div>
<div class="project_01_second_div"><a href="//www.behance.net/gallery/153255059/Upaj-A-web-platform-to-empower-farmers"><img src="images/Upaj_website_cover.png" alt="Upaj website cover image"></a></div>
</div>

<div class="flex_container_project_02"><p>That's not all. Few more to go!</p></div><!--Sub-container 02-->

<div class="flex_container_project_03"><!--Sub-container 03-->
<div class="flex_container_project_03_first_div"><a href="//www.behance.net/gallery/161637351/Retailer-App"><img src="images/retaler_cover.png" alt="App for Retailer project cover image"></a></div>
<div class="flex_container_project_03_first_div"><a href="//www.behance.net/gallery/96074949/Biogas-App-UI"><img src="images/biogas_cover.jpg" alt="App on biogas cover image"></a></div>
<div class="flex_container_project_03_first_div"><a href="//www.behance.net/gallery/160922387/Ledger-App"><img src="images/ledger_cover.jpg" alt="App for managing ledger cover image"></a></div>
<div class="flex_container_project_03_first_div"><a href="//www.behance.net/gallery/121035629/Website-Design-UIUX"><img src="images/doctor_cover.jpg" alt="Website for doctore cover image"></a></div>
</div>
</div>

<footer>
<div class="flex-container_footer">
<div class="flex-container_footer_first_div">
<p>Wanna talk?</p></div>
<div class="flex-container_footer_second_div">
Reach me out at [email protected]
</div>
</div>
</footer>

</body>
</html>
55 changes: 55 additions & 0 deletions portfolio_website_services.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
<!doctype html>
<html lang="en">

<head>
<link rel="stylesheet" href="style_homepage.css">
<meta charset="utf-8">
<title>Ishmeet-Services</title>
</head>

<body>
<div class="header">
<div class="my-name">Ishmeet Kaur</div>
<div class="header-menu">
<nav>
<ul>
<li><a href="portfolio_website.html">Home</a></li>
<li><a href="portfolio_website_services.html">Services</a></li>
<li><a href="portfolio_website_projects.html">Projects</a></li>
<li><a href="portfolio_website_contact.html">Contact</a></li>
</ul>
</nav>
</div>
</div>

<div class="flex_container_services">
<div class="flex_container_services_01">
<h1>I design to provide you these services!</h1>
</div>
<div class="flex_container_services_02"><!--alt text added for accessibility-->
<div class="services_02_first_div"><a href="//shorturl.at/juBCM"><img src="images/accessibility-icon.png" alt="accessible design"></a>
<p>Accessible</p></div>
<div class="services_02_first_div"><a href="//wiredimpact.com/blog/7-characteristics-user-friendly-website/"><img src="images/user-friendly-icon.png" alt="user friendly design"></a>
<p>Usability</p></div>
<div class="services_02_first_div"><a href="//wiredimpact.com/blog/7-characteristics-user-friendly-website/"><img src="images/easy-to-use-icon.png" alt="Easy to use design"></a>
<p>Easy to navigate</p></div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be clearer that these links are external links. As it is, I expect to see something on the same website about each of these topics.

<div class="flex_container_services_03">
<div class="services_03_first_div"><a href="//shorturl.at/imswY"><img src="images/responsive-icon.png" alt="responsive design"></a>
<p>Responsive</p></div>
<div class="services_03_first_div"><a href="//www.semrush.com/blog/what-is-a-call-to-action/"><img src="images/cta-icon.png" alt="clear cta"></a>
<p>Clear CTAs</p></div>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is not linked properly here because these images do not show up:

image


<footer>
<div class="flex-container_footer">
<div class="flex-container_footer_first_div">
<p>Wanna talk?</p></div>
<div class="flex-container_footer_second_div">
Reach me out at [email protected]</div>
</div>
</footer>

</body>
</html>
Binary file added responsive-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading