Feedback #1
Feedback #1
Conversation
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
This reverts commit 6169b3e.
This reverts commit 48ebec9.
first commit
merging code from feature branch to main branch
Made changes to the icon colors, remove extra property added to p, added two more sections to services page and added links respective to each section
Stylesheet, services page and updated icons
six image manipulation
There was a problem hiding this comment.
The homepage file should generally be named index.html so that it is automatically picked up by browsers looking at the URL for the website. If you go here, it doesn't exist, but usually this link should work if you have an index.html file.
https://birkbeck2.github.io/web-development-website-project-ikaur02/You have to go here instead, which is not intuitive:
https://birkbeck2.github.io/web-development-website-project-ikaur02/portfolio_website.html
| <li><a href="portfolio_website_projects.html">Projects</a></li> | ||
| <li><a href="portfolio_website_contact.html">Contact</a></li> | ||
| </ul> | ||
| </nav> |
| <div class="flex-container_footer_second_div"> | ||
| Reach me out at [email protected]</div> | ||
| </div> | ||
| </footer> |
There was a problem hiding this comment.
These are called "flex container" but there are no flex display rules applied. Generally the CSS names should be easy to read to get a sense of what is happening in the code, but this does not give the right impression.
Decent basic use of semantic HTML for the footer.
| <div class="work_01_first_div"> | ||
| <p>I do experiments & write it down called as Research projects!</p></div> | ||
| <div class="work_01_second_div"><img src="images/KFC_cover.png" alt="KFC project cover image"></div> | ||
| <div class="work_01_second_div"><img src="images/Upaj_website_cover.png" alt="Upaj website cover image"></div> |
| </div> | ||
|
|
||
| <div class="flex_container_work_02"> | ||
| <button>View more</button></div> |
There was a problem hiding this comment.
Good that this is a semantic button element, but it doesn't do anything. What should happen when the user clicks this? The interaction design is not clear to me.
There was a problem hiding this comment.
The user will be directed to projects page and able to view all the projects
style_homepage.css
Outdated
| { | ||
| display: flex; | ||
| height: 150px; | ||
| flex-direction: column; |
There was a problem hiding this comment.
Good use of media queries to change the flex direction!
style_homepage.css
Outdated
| height: 3rem; | ||
| border-radius: 30px; | ||
| margin-top: 20px; | ||
| box-shadow: 0px 5px 15px 0px rba(28,0,181,0.3); |
There was a problem hiding this comment.
Where did this code come from? It is not taking effect in the website because rga is not a valid CSS function.
But the point is that this should be explained or a source cited.
style_homepage.css
Outdated
| { | ||
| box-shadow: 0 0 2px 1px rgba(0, 140, 186, 0.5); | ||
| filter:grayscale(100%) | ||
| } |
There was a problem hiding this comment.
These classes are named with 01, 02, 03, and very similar names like "flex container" at the beginning of every one. This makes it very hard to read the HTML and compare it to the CSS, and so it makes it harder for you to debug when there are issues. Next time try writing more expressive names, like gallery and gallery-item. If you want to differentiate the small and big galleries, you could have big-gallery, big-gallery-item, small-gallery, small-gallery-item.
style_homepage.css
Outdated
| filter:grayscale(100%) | ||
| } | ||
|
|
||
| /*Media Query for Mobile - Global styling*/ |
There was a problem hiding this comment.
You have another media query for global styling of mobile above. Is it duplicated?
style_homepage.css
Outdated
| max-width: 40%; | ||
| } | ||
|
|
||
| /*Media Query for Mobile - Global styling*/ |
There was a problem hiding this comment.
Again the media query for global mobile styling is duplicated.
Revert "Merge pull request #3 from Birkbeck2/Full_code"
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @ikaur02