Use naive hash fallback for BioSequence #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current hashing behaviour hashes equal biosequences with different encodings to different values, which violate the interface of hash. This is a fix until (and if) we figure out a better method of hashing. See issue BioJulia#243
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
- Coverage 89.27% 88.75% -0.53%
==========================================
Files 31 30 -1
Lines 2425 2321 -104
==========================================
- Hits 2165 2060 -105
- Misses 260 261 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Codecov is an artifact of suddenly having less (tested) source code, meaning the untested fraction increases - this is completely covered by tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current hashing behaviour hashes equal biosequences with different encodings to
different values, which violate the interface of hash.
This is a fix until (and if) we figure out a better method of hashing.
See issue #243
Going to immediately release this as a new version if tests pass, cc @kescobo @SabrinaJaye