Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sqlite bool conversion and int-test #53

Merged
merged 4 commits into from
Sep 16, 2024
Merged

add sqlite bool conversion and int-test #53

merged 4 commits into from
Sep 16, 2024

Conversation

zargot
Copy link
Collaborator

@zargot zargot commented Sep 11, 2024

fixes #21

@zargot zargot requested a review from yulric September 11, 2024 19:14
@zargot zargot linked an issue Sep 11, 2024 that may be closed by this pull request
test db input #21
Closed
yulric
yulric requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@yulric yulric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also pushed a commit that uses the sqlalchemy API to set the boolean cols for a databse.

tests/int_tests.py Show resolved Hide resolved
@zargot
Copy link
Collaborator Author

zargot commented Sep 13, 2024

Also pushed a commit that uses the sqlalchemy API to set the boolean cols for a databse.

that's great, I didn't know I could do that.

@zargot zargot merged commit 0969d7d into impl Sep 16, 2024
3 checks passed
@zargot zargot deleted the db-test branch September 16, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yulric yulric yulric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test db input
2 participants
@zargot @yulric