Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules: handle dup rule id edge case #45

Merged
merged 2 commits into from
Sep 4, 2024
Merged

rules: handle dup rule id edge case #45

merged 2 commits into from
Sep 4, 2024

Conversation

zargot
Copy link
Collaborator

@zargot zargot commented Aug 26, 2024 •
edited
Loading

fixes #35

@zargot zargot requested a review from yulric August 26, 2024 19:33
@zargot zargot linked an issue Aug 26, 2024 that may be closed by this pull request
schema: repeating rule ids gives misleading error message #35
Closed
@zargot zargot changed the title trees: handle dup rule id edge case rules: handle dup rule id edge case Aug 26, 2024
@zargot zargot marked this pull request as draft August 27, 2024 14:38
@zargot zargot changed the base branch from impl to int-test August 29, 2024 17:05
@zargot zargot marked this pull request as ready for review August 29, 2024 17:07
Base automatically changed from int-test to impl September 4, 2024 17:15
@zargot zargot merged commit dc3aed3 into impl Sep 4, 2024
3 checks passed
@zargot zargot deleted the 35-dup-rule-id branch September 4, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yulric yulric yulric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schema: repeating rule ids gives misleading error message
2 participants
@zargot @yulric