Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paredit Multicursor - Rewrap #2474

Merged
merged 5 commits into from
Mar 31, 2024
Merged

Paredit Multicursor - Rewrap #2474

merged 5 commits into from
Mar 31, 2024

Conversation

riotrah
Copy link
Member

@riotrah riotrah commented Mar 30, 2024

What has changed?

  • Implement multicursor for paredit rewrap
  • Like my other multicursor work this time, extracted command logic into a commands.ts file, adding some indirection and opt-in multicursor based on user setting etc
  • Add tests

Originally this was going to include multicursor wrap (now a WIP at #2472 ), but a couple of test cases keeping failing, so here's rewrap alone!

Fixes #2473

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@riotrah riotrah added the paredit Paredit and structural editing label Mar 30, 2024
@riotrah
Copy link
Member Author

riotrah commented Mar 30, 2024

rebase onto dev incoming!

Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for calva-docs failed.

Name Link
🔨 Latest commit b1c3e1c
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/6607ad958510dd00080b8073

@riotrah riotrah force-pushed the wip/rayat/paredit/multicursor/rewrap branch from 3138db3 to b1c3e1c Compare March 30, 2024 06:13
@riotrah
Copy link
Member Author

riotrah commented Mar 31, 2024

@PEZ both this pr and the selectCurrentForm one both seem to fail the netlify deploy process, I'm guessing from the paredit docsite changes - but I can't derive any useful info from the deploy logs.

@PEZ PEZ merged commit 8d83117 into dev Mar 31, 2024
1 of 5 checks passed
@PEZ PEZ deleted the wip/rayat/paredit/multicursor/rewrap branch March 31, 2024 12:36
@riotrah riotrah linked an issue Mar 31, 2024 that may be closed by this pull request
@riotrah riotrah self-assigned this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paredit Paredit and structural editing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paredit Multicursor - Rewrap
2 participants