-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paredit Multicursor - SelectCurrentForm #2477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@PEZ both this pr and the |
12 tasks
PEZ
reviewed
Mar 31, 2024
riotrah
force-pushed
the
wip/rayat/paredit/multicursor/select-current-form
branch
from
March 31, 2024 22:08
9ebcb7c
to
d4257ec
Compare
riotrah
force-pushed
the
wip/rayat/paredit/multicursor/select-current-form
branch
from
March 31, 2024 22:10
d4257ec
to
2957cc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
This PR is targeting my other PR #2474 's branch, such that once that gets merged, this should automatically targetdev
, but I'll leave the 2nd branch target checkbox unmarked just in case for nowselectCurrentForm
src/select.ts
and exposure under rootcommands, into a rewritten version incalva.selectCurrentForm
src/cursor-doc/paredit.ts
/commands.ts
/src/paredit/extension.ts
like the other paredit multicursor rewrites exposed asparedit.selectCurrentForm
.Fixes #2476
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.npm run prettier-format
)npm run eslint
before creating your PR, or runnpm run eslint-watch
to eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik