Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paredit Multicursor - SelectCurrentForm #2477

Merged
merged 10 commits into from
Apr 1, 2024

Conversation

riotrah
Copy link
Member

@riotrah riotrah commented Mar 30, 2024

What has changed?

This PR is targeting my other PR #2474 's branch, such that once that gets merged, this should automatically target dev, but I'll leave the 2nd branch target checkbox unmarked just in case for now

  • Implement multicursor selectCurrentForm
  • Removes its previous implementation in src/select.ts and exposure under root calva.selectCurrentForm commands, into a rewritten version in src/cursor-doc/paredit.ts/commands.ts/src/paredit/extension.ts like the other paredit multicursor rewrites exposed as paredit.selectCurrentForm.
    • [EDIT]: just keeps the previous command id for backwards compat, thanks @PEZ
  • Adds tests for single and multi cursor

Fixes #2476

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@riotrah riotrah added the paredit Paredit and structural editing label Mar 30, 2024
@riotrah riotrah requested a review from PEZ March 30, 2024 21:24
Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit 5e466d8
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/6609e03a64659f0008adc8ba
😎 Deploy Preview https://deploy-preview-2477--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@riotrah
Copy link
Member Author

riotrah commented Mar 31, 2024

@PEZ both this pr and the rewrap one both seem to fail the netlify deploy process, I'm guessing from the paredit docsite changes - but I can't derive any useful info from the deploy logs.

Base automatically changed from wip/rayat/paredit/multicursor/rewrap to dev March 31, 2024 12:36
package.json Show resolved Hide resolved
@riotrah riotrah linked an issue Mar 31, 2024 that may be closed by this pull request
@riotrah riotrah self-assigned this Mar 31, 2024
@riotrah riotrah force-pushed the wip/rayat/paredit/multicursor/select-current-form branch from 9ebcb7c to d4257ec Compare March 31, 2024 22:08
@riotrah riotrah force-pushed the wip/rayat/paredit/multicursor/select-current-form branch from d4257ec to 2957cc9 Compare March 31, 2024 22:10
@riotrah riotrah requested a review from PEZ March 31, 2024 22:10
@PEZ PEZ merged commit 19e4689 into dev Apr 1, 2024
5 checks passed
@PEZ PEZ deleted the wip/rayat/paredit/multicursor/select-current-form branch April 1, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paredit Paredit and structural editing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paredit Multicursor - SelectCurrentForm
2 participants