Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added relativity equation in Java #76

Merged
merged 3 commits into from
Oct 4, 2017
Merged

Added relativity equation in Java #76

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c2c896
Added relativity equation in Java
robertoduessmann Oct 3, 2017
8bf3553
Code review - remove main method and return the result directly
robertoduessmann Oct 3, 2017
e5911d8
Renamed relativity equation to pattern
robertoduessmann Oct 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions physics/relativity_equation/java/RelativityEquation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/**
* Created by robertoduessmann on 03/10/17.
*/
public class RelativityEquation {

private static final double SPEED_LIGHT = 299792458;

public static double getEnergy(double mass) {
double energy = mass * Math.pow( SPEED_LIGHT, 2 );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need a local variable when we just return immediately?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's do that. It's clear this is energy. Maybe have a comment saying e = m*c^2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, don't need!
I created only to try be clearer, but isn't necessary... I will remove 👍

return energy;
}

public static void main(String[] args) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I've created only to test :)

System.out.println( getEnergy( 10 ) );
}

}