Added relativity equation in Java #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepfair
reviewed
Oct 3, 2017
| private static final double SPEED_LIGHT = 299792458; | ||
|
|
||
| public static double getEnergy(double mass) { | ||
| double energy = mass * Math.pow( SPEED_LIGHT, 2 ); |
There was a problem hiding this comment.
Do you need a local variable when we just return immediately?
There was a problem hiding this comment.
Yeah, let's do that. It's clear this is energy. Maybe have a comment saying e = m*c^2
There was a problem hiding this comment.
Great, don't need!
I created only to try be clearer, but isn't necessary... I will remove 👍
mdew192837
reviewed
Oct 3, 2017
| private static final double SPEED_LIGHT = 299792458; | ||
|
|
||
| public static double getEnergy(double mass) { | ||
| double energy = mass * Math.pow( SPEED_LIGHT, 2 ); |
There was a problem hiding this comment.
Yeah, let's do that. It's clear this is energy. Maybe have a comment saying e = m*c^2
| return energy; | ||
| } | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
Nice, I've created only to test :)
Thanks for the feedbacks @mdew192837 and @stepfair |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added relativity equation in Java.
For #3
refs https://github.com/robertoduessmann/physicalc