-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
potential fix for CI #83
Conversation
This is not needed IMO. For deployment lint runs with Having |
Thanks, you are absolutely right, I changed this by accident. I fixed that in 69065ea. |
Sorry, this is not what I meant .. Give me a moment. Ultimately biii needs to be added here .. which will effect only with the next galaxy release. |
Yes, this is why I have changed it from - name: Planemo lint
if: ${{ github.event_name == 'pull_request' }}
Yes, this is what we had already done in 00a3d03, and why we wanted to bypass linting for merging for the moment, until the next Galaxy release is there. |
The requirement is that the CI deploys tools even if planemo lint raises an error during merge.
The current configuration of the CI sets
--fail_level
passed toplanemo shed_lint
toerror
:https://github.com/BMCV/galaxy-image-analysis/actions/runs/6811812716/job/18523060276#step:7:355
To my understanding, this makes the linter fail only if it produces an error (but not if it produces warnings).
https://help.galaxyproject.org/t/make-a-repository-installable/8156/6
What we want instead, is, that the linter never fails during merge, not even if an error is encountered! However, only the options
warn
anderror
are allowed:Thus, the required behavior is out of scope of
fail_level
. It can only be achieved by skipping linting during merge. This should be implemented by this PR (hopefully, never digged myself into GitHub actions before).xref #82 #71
FOR CONTRIBUTOR: