-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trigger ci, deploy missing tools #82
Conversation
What is different to IUC is that IUC is using the Maybe we can ask @bernt-matthias if he has any ideas why the deployment is skipped when linting is failing. |
Lets see whether it works now with the recent changes… |
…nope. Deployment was skipped again: https://github.com/BMCV/galaxy-image-analysis/actions/runs/6811812716 Would be great if @bernt-matthias could have a look at this! Thanks… |
CI is fine. Lint runs with Problem with the linked run is that there is really an error:
|
Yes, thanks @bernt-matthias, I think this is what I had just addressed in #83 |
Just to be sure: #83 will not help with the deployment since there is really an error in the tool that needs to be fixed. |
How I understood @bgruening was that we want to deploy those tools regardless of the linting issue, until this is included in a release of Galaxy. Is skipping planemo lint during merge the way to go then? |
Then you would need to skip linting completely during merge (which I would consider to be very dangerous .. since you need to check the linter output really careful in each and every PR). The error because of the xref type |
@bernt-matthias we added this new type to the Galaxy 23.1 branch. its a bio.tools for imaging. http://biii.eu/ |
trigger ci after #81 to deploy the tools which haven't been deployed from #76
xref #71
FOR CONTRIBUTOR: