Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger ci, deploy missing tools #82

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

kostrykin
Copy link
Member

trigger ci after #81 to deploy the tools which haven't been deployed from #76

xref #71


FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the galaxy-image-analysis repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)
  • - Tools added/updated by this PR (if any) comply with the Naming and Annotation Conventions for Tools in the Image Community in Galaxy (or please explain why they do not)

@bgruening
Copy link
Collaborator

What is different to IUC is that IUC is using the main branch and not the master branch. But I checked the CI and it respects both.

Maybe we can ask @bernt-matthias if he has any ideas why the deployment is skipped when linting is failing.

@kostrykin
Copy link
Member Author

What is different to IUC is that IUC is using the main branch and not the master branch. But I checked the CI and it respects both.

Maybe we can ask @bernt-matthias if he has any ideas why the deployment is skipped when linting is failing.

Lets see whether it works now with the recent changes…

@kostrykin kostrykin merged commit 45bd1f1 into BMCV:master Nov 9, 2023
8 of 10 checks passed
@kostrykin
Copy link
Member Author

…nope. Deployment was skipped again: https://github.com/BMCV/galaxy-image-analysis/actions/runs/6811812716

Would be great if @bernt-matthias could have a look at this! Thanks…

@kostrykin kostrykin mentioned this pull request Nov 9, 2023
6 tasks
@bernt-matthias
Copy link
Contributor

CI is fine. Lint runs with --fail_level error on merge. This is decided here

Problem with the linked run is that there is really an error:

.. ERROR: Invalid XML found in file: tmpakqe62wn. Errors [/tmp/tmpakqe62wn:8:0:ERROR:SCHEMASV:SCHEMAV_CVC_ENUMERATION_VALID: Element 'xref', attribute 'type': [facet 'enumeration'] The value 'biii' is not an element of the set {'bio.tools', 'bioconductor'}.]

@kostrykin
Copy link
Member Author

Yes, thanks @bernt-matthias, I think this is what I had just addressed in #83

@bernt-matthias
Copy link
Contributor

Just to be sure: #83 will not help with the deployment since there is really an error in the tool that needs to be fixed.

@kostrykin
Copy link
Member Author

How I understood @bgruening was that we want to deploy those tools regardless of the linting issue, until this is included in a release of Galaxy. Is skipping planemo lint during merge the way to go then?

@bernt-matthias
Copy link
Contributor

Then you would need to skip linting completely during merge (which I would consider to be very dangerous .. since you need to check the linter output really careful in each and every PR).

The error because of the xref type biii (what is this btw?) will cause linting to fail in any case.

@bgruening
Copy link
Collaborator

@bernt-matthias we added this new type to the Galaxy 23.1 branch. its a bio.tools for imaging. http://biii.eu/
The problem is that we don't have new packages yet, so linting is failing - which is fine imho for a short period of time until we get new packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants