-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify management of MSRV #1335
Merged
Merged
unify management of MSRV #1335
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c0c67e7
unify management of MSRV
ec3c321
try removing msrv from matrix strategy
e1ff136
fix syntax error
46409d0
fix set-output syntax
9293807
remove extra }
878dbfc
add using msrv for codestyle
fba51b1
matrix off of `msrv` task across the pipeline
85a3169
install required components
14b80c1
bump msrv to 1.65.0 due to time-core dependency
8e1d971
update MSRV to 1.67.0 due to dependency on `time`
4e2e078
ensure rustfmt is installed for testing services
d15711e
Merge branch 'main' into standardize-msrv
demoray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,22 +9,39 @@ env: | |
CARGO_INCREMENTAL: 0 | ||
|
||
jobs: | ||
msrv: | ||
name: Get minimum supported rust version | ||
runs-on: ubuntu-20.04 | ||
outputs: | ||
msrv: ${{ steps.get_msrv.outputs.msrv }} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- id: get_msrv | ||
run: | | ||
MSRV=$(cargo metadata --format-version=1 --no-deps | jq '.packages[] | select(.name == "azure_core").rust_version' -r) | ||
echo setting msrv to ${MSRV} | ||
echo msrv=${MSRV} >> "$GITHUB_OUTPUT" | ||
|
||
code-style: | ||
name: Code Style | ||
runs-on: ubuntu-20.04 | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: Swatinem/rust-cache@v2 | ||
- run: eng/scripts/code_style.sh | ||
# for code style, we only care about `stable` | ||
- run: eng/scripts/code_style.sh stable | ||
|
||
test-sdk: | ||
name: SDK Tests | ||
runs-on: ubuntu-20.04 | ||
needs: | ||
- msrv | ||
strategy: | ||
matrix: | ||
build: | ||
- stable | ||
- nightly | ||
- ${{ needs.msrv.outputs.msrv }} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: Swatinem/rust-cache@v2 | ||
|
@@ -33,39 +50,56 @@ jobs: | |
test-services: | ||
name: Services Tests | ||
runs-on: ubuntu-20.04 | ||
needs: | ||
- msrv | ||
strategy: | ||
matrix: | ||
build: | ||
- stable | ||
- nightly | ||
- ${{ needs.msrv.outputs.msrv }} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: Swatinem/rust-cache@v2 | ||
- run: eng/scripts/services_tests.sh | ||
- run: eng/scripts/services_tests.sh ${{ matrix.build }} | ||
- name: display free disk space | ||
run: df -h / | ||
if: ${{ always() }} | ||
|
||
test-integration: | ||
name: Integration Tests | ||
runs-on: ubuntu-20.04 | ||
needs: | ||
- msrv | ||
strategy: | ||
matrix: | ||
build: | ||
- stable | ||
- nightly | ||
- ${{ needs.msrv.outputs.msrv }} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- run: rustup update --no-self-update stable | ||
- uses: Swatinem/rust-cache@v2 | ||
|
||
- name: emulator integration tests | ||
run: | | ||
npm install [email protected] | ||
npx azurite & | ||
cargo test --features test_integration | ||
|
||
- run: eng/scripts/emulator_tests.sh ${{ matrix.build }} | ||
- name: display free disk space | ||
run: df -h / | ||
if: ${{ always() }} | ||
|
||
test-e2e: | ||
name: E2E Tests | ||
runs-on: ubuntu-20.04 | ||
needs: | ||
- msrv | ||
strategy: | ||
matrix: | ||
build: | ||
- stable | ||
- nightly | ||
- ${{ needs.msrv.outputs.msrv }} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: Swatinem/rust-cache@v2 | ||
- run: eng/scripts/e2e_tests.sh | ||
- run: eng/scripts/e2e_tests.sh ${{ matrix.build }} | ||
- name: display free disk space | ||
run: df -h / | ||
if: ${{ always() }} | ||
|
@@ -88,4 +122,5 @@ jobs: | |
with: | ||
repository: OAI/OpenAPI-Specification | ||
path: OpenAPI-Specification | ||
# for code style, we only care about `stable` | ||
- run: azure-sdk-for-rust/eng/scripts/autorust_tests.sh |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#!/bin/bash | ||
|
||
set -eux -o pipefail | ||
cd $(dirname ${BASH_SOURCE[0]})/../../ | ||
|
||
BUILD=${1:-stable} | ||
|
||
npm install [email protected] | ||
npx azurite & | ||
|
||
rustup update --no-self-update ${BUILD} | ||
cargo +${BUILD} test --features test_integration |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one place. Loos like the right spot.