Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify management of MSRV #1335

Merged
merged 12 commits into from
Aug 17, 2023
Merged

unify management of MSRV #1335

merged 12 commits into from
Aug 17, 2023

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Aug 16, 2023

This PR standardizes where all crates set the MSRV (azure_core), as well as updates the actions to build on a matrix of 'stable', 'nightly', and the rust-version set in azure_core.

This allows developers of the SDK to run each of the build tasks exactly as they are run in CICD with minimal configuration.

Brian Caswell added 11 commits August 16, 2023 10:26
This PR standardizes where all crates set the MSRV (azure_core), as well as updates the actions to build on a matrix of 'stable', 'nightly', and the rust-version set in `azure_core`.

This allows developers of the SDK to run each of the build tasks exactly as they are run in CICD with minimal configuration.
@demoray demoray requested a review from cataggar August 17, 2023 16:04
Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the infrastructure work.

@@ -11,7 +11,7 @@ documentation = "https://docs.rs/azure_core"
keywords = ["sdk", "azure", "rest", "iot", "cloud"]
categories = ["api-bindings"]
edition = "2021"
rust-version = "1.64.0"
rust-version = "1.67.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one place. Loos like the right spot.

@demoray demoray merged commit f6d2565 into Azure:main Aug 17, 2023
16 checks passed
@demoray demoray deleted the standardize-msrv branch September 20, 2023 11:31
@demoray demoray restored the standardize-msrv branch September 20, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants