Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic Links: The one PR to rule them all #1205

Merged
merged 97 commits into from
Jul 26, 2024
Merged

Magic Links: The one PR to rule them all #1205

Show file tree
Hide file tree
Changes from 94 commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
10bc7ce
Use secondary action to move to the email view instead of switch
charliescheer Jul 22, 2024
6fa0e2c
Removed the switch mode button
charliescheer Jul 22, 2024
a670f8e
Redesign wordpress sso button
charliescheer Jul 22, 2024
41ee55b
Added app title to the onboarding screen
charliescheer Jul 23, 2024
a12c5e4
Updated authenticationVC to use action descriptors
charliescheer Jul 23, 2024
7ba9271
Dropped secondary view boolean and animation size props
charliescheer Jul 23, 2024
b5ad6fd
Updated wordpress sso button to be the tertiary button
charliescheer Jul 23, 2024
c520774
removed unused changes to wordpress button
charliescheer Jul 23, 2024
5daedbf
Updated authentication mode to include different input values
charliescheer Jul 23, 2024
0779ce1
Dropped switch target mode
charliescheer Jul 23, 2024
5fc7e7e
Dropped isWordpressVisible on authenticationMode
charliescheer Jul 23, 2024
40b97e7
Removed show action separator
charliescheer Jul 23, 2024
112e927
Fixed wordpress sso button crash
charliescheer Jul 23, 2024
1a437d4
added SPAuthSessionKey to user defaults keys
charliescheer Jul 23, 2024
78d58c9
Added code input view
charliescheer Jul 23, 2024
7294414
Merge pull request #1194 from Automattic/charlie/magic-link-ui
charliescheer Jul 24, 2024
8f2978f
Add auth with code view
charliescheer Jul 24, 2024
9d09f06
Added login with password screen and actions
charliescheer Jul 24, 2024
b2e2a34
Adde code authentication
charliescheer Jul 24, 2024
5f0be57
Dropped remaining fading animation changes to auth view
charliescheer Jul 24, 2024
50b4829
NavigationController: Drops Back Button Height Animation
jleandroperez Jul 24, 2024
4ec31a7
NavigationController: Updates Attach API Signature
jleandroperez Jul 24, 2024
c88bfdc
NavigationController: Updates popViewController API
jleandroperez Jul 24, 2024
1aaa3ac
NavigationController
jleandroperez Jul 24, 2024
70a3188
Fixed animation names on primary button
charliescheer Jul 24, 2024
4422b7b
NavigationController: Fixes resizing animation
jleandroperez Jul 24, 2024
8d04f77
Added error handling on code auth
charliescheer Jul 24, 2024
8b25766
Fixed issue where on signup > back the buttons don't work
charliescheer Jul 24, 2024
6c22d00
Fixed hitting enter in auth text field not running the primary command
charliescheer Jul 24, 2024
8891487
Make first text field take first responder on authVC appear
charliescheer Jul 24, 2024
b00cd56
added super.viewDidAppear to override method in authVC
charliescheer Jul 24, 2024
01b6dad
Dropped unused setMode method on auth VC
charliescheer Jul 24, 2024
27d624c
Added header text to auth view
charliescheer Jul 24, 2024
5df2e1e
Fixed enter password border to correct size
charliescheer Jul 24, 2024
2eed460
Added validation of login code input
charliescheer Jul 24, 2024
7657547
Set progress indicator on auth view to white
charliescheer Jul 24, 2024
2b78073
Merge pull request #1196 from Automattic/lantean/1187-updates-navbar-…
jleandroperez Jul 24, 2024
aa04da5
Merge pull request #1195 from Automattic/charlie/magic-links-ui-mk3
charliescheer Jul 24, 2024
9d2ea0b
Merge branch 'feature/1187-magic-links' into charlie/magic-links-ui-mk4
charliescheer Jul 24, 2024
b87ecff
Removed commenting out some code that wasn't supposed to get committed
charliescheer Jul 24, 2024
e9dcc5c
Updated quarternary button color
charliescheer Jul 24, 2024
7049055
Merge pull request #1197 from Automattic/charlie/magic-links-ui-mk4
charliescheer Jul 24, 2024
3c11525
Refactored how the auth view controller is initialized
charliescheer Jul 24, 2024
3f63677
Show code input on auth view controller
charliescheer Jul 25, 2024
78b48bd
Added password header to sp auth with password view
charliescheer Jul 25, 2024
3d352de
Dont highlight email text when becoming first responder on back
charliescheer Jul 25, 2024
2e972b5
Fixed issue going to link invalid view back made auth not clickable
charliescheer Jul 25, 2024
dda5310
Removed comments on code that requests login codes
charliescheer Jul 25, 2024
fd6845f
Wires SimplenoteEndpoints SPM
jleandroperez Jul 25, 2024
33f7d15
Drops duplicated code
jleandroperez Jul 25, 2024
0190e67
Drops duplicated tests
jleandroperez Jul 25, 2024
25e030c
Wires SimplenoteEndpoints Mark 1.0.0
jleandroperez Jul 25, 2024
a861df5
Implements AuthenticationError
jleandroperez Jul 25, 2024
a836f0b
AuthenticationMode: Adds missing newline
jleandroperez Jul 25, 2024
93dafff
AuthViewController: Exposing Alert API(s)
jleandroperez Jul 25, 2024
d76ea14
AuthViewController: Wires AuthenticationError
jleandroperez Jul 25, 2024
5ce7710
AuthViewController: Drops legacy code
jleandroperez Jul 25, 2024
e675d46
AuthViewController: Wires requestNotFound
jleandroperez Jul 25, 2024
5e08a6a
Improved back button appearance
charliescheer Jul 26, 2024
045295c
Updated text for login with email button
charliescheer Jul 26, 2024
e10baeb
Merge pull request #1198 from Automattic/charlie/magic-links-mk5
charliescheer Jul 26, 2024
e2b670b
AuthViewController: Handling requestNotFound Error
jleandroperez Jul 26, 2024
b566a3c
AuthViewController: Drops optionals
jleandroperez Jul 26, 2024
262e53b
Merge branch 'feature/1187-magic-links' into lantean/wiring-simplenot…
jleandroperez Jul 26, 2024
4138485
Merge pull request #1199 from Automattic/lantean/wiring-simplenote-en…
jleandroperez Jul 26, 2024
e23dea3
Merge pull request #1200 from Automattic/lantean/1187-error-handling-…
jleandroperez Jul 26, 2024
83ae9e8
Merge pull request #1201 from Automattic/lantean/1187-invalid-code-ha…
jleandroperez Jul 26, 2024
c41d64d
AuthViewController: Fixes warning
jleandroperez Jul 26, 2024
d41677e
AuthViewController: Fixes incorrect invocation
jleandroperez Jul 26, 2024
20781d4
AuthViewController: username and password now depend on the State
jleandroperez Jul 26, 2024
275b492
AuthViewController: Adds missing trimming
jleandroperez Jul 26, 2024
5cbb302
AuthViewController: Updates API visibility
jleandroperez Jul 26, 2024
7e5a60a
AuthViewController: Drops dead API(s)
jleandroperez Jul 26, 2024
9608f74
SPNavigationController: Window Animation WIP
jleandroperez Jul 26, 2024
f128d17
Removed magic numbers when setting navigation controller back button
charliescheer Jul 26, 2024
2869824
Dropped setting view bottom constraints in favor of calculated height
charliescheer Jul 26, 2024
3cf78c8
Removed calculation for padding height
charliescheer Jul 26, 2024
37a9d8a
Allow for navigation controller to not animate view size changes
charliescheer Jul 26, 2024
d25e7a8
Setup height constraint in loadView instead of lazy var
charliescheer Jul 26, 2024
ee044c2
Refactor creating the height constraint for sp nav controller
charliescheer Jul 26, 2024
d2481f6
AuthenticationMode: RateLimiting Fallback
jleandroperez Jul 26, 2024
95a74e7
Fixed back button not hiding when back to initial vc w/o animations
charliescheer Jul 26, 2024
e9d8905
Refactored nav controller .attachView to not return constraints
charliescheer Jul 26, 2024
cf9a815
Merge pull request #1202 from Automattic/lantean/1187-debt-fixes
jleandroperez Jul 26, 2024
a31ea9e
Merge pull request #1203 from Automattic/lantean/1187-rate-limiting-f…
jleandroperez Jul 26, 2024
f7fc044
removed unused .animator() call when not animating
charliescheer Jul 26, 2024
d86ecd7
dropped unused self in nav controller
charliescheer Jul 26, 2024
1cb42ff
Drop unneeded return
charliescheer Jul 26, 2024
8afb39f
Removed the low priority height constraint, it wasnt needed anymore
charliescheer Jul 26, 2024
be3e363
Refactored window animation out of attach sub view
charliescheer Jul 26, 2024
04041c4
fixed calculated top padding size
charliescheer Jul 26, 2024
25c19af
Dropped unused animated argument in attachView
charliescheer Jul 26, 2024
cf8a7a5
Dropped unused height constraint change
charliescheer Jul 26, 2024
7d63262
Merge pull request #1204 from Automattic/charlie/1187-window-animation
charliescheer Jul 26, 2024
6ac8089
Dropped conflicting constraint when setting up navigation view
charliescheer Jul 26, 2024
dd58f3b
Updated language for requesting email code
charliescheer Jul 26, 2024
0813755
Updated button and header strings for auth
charliescheer Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 29 additions & 60 deletions Simplenote.xcodeproj/project.pbxproj
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 10 additions & 1 deletion Simplenote.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"originHash" : "1f66ac352dc04da5870abacba5f42306bd560111ad295c7c60a13a7af5c25ec8",
"originHash" : "7f8dc02b0065be779873bdc5b585794a5005edfeb5a5e51a04644d5b3c18e322",
"pins" : [
{
"identity" : "automattic-tracks-ios",
Expand All @@ -19,6 +19,15 @@
"version" : "8.28.0"
}
},
{
"identity" : "simplenoteendpoints-swift",
"kind" : "remoteSourceControl",
"location" : "https://github.com/Automattic/SimplenoteEndpoints-Swift",
"state" : {
"revision" : "3d1c0a5db39ca798a7de10e7faeef8ae66e941e6",
"version" : "1.0.0"
}
},
{
"identity" : "simplenotefoundation-swift",
"kind" : "remoteSourceControl",
Expand Down
2 changes: 2 additions & 0 deletions Simplenote/AccountDeletionController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import Foundation
import SimplenoteEndpoints


@objc
class AccountDeletionController: NSObject {
Expand Down
57 changes: 0 additions & 57 deletions Simplenote/AccountRemote.swift
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions Simplenote/AccountVerificationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import Foundation
import SimplenoteEndpoints


// MARK: - AccountVerificationController
//
Expand Down
Loading
Loading