Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Links: The one PR to rule them all #1205

Merged
merged 97 commits into from
Jul 26, 2024
Merged

Conversation

charliescheer
Copy link
Contributor

Fix

... one PR to find them, one PR to bring them all, and in the darkness bind them...

This PR brings together all of the previous changes to magic links authorization that has been made on SNMac and then merges them all back into trunk. There aren't any unreviewed changes here (although we might make some button copy changes before merging) but we should smoke test the auth views before we merge it back to trunk and then release the new auth to the masses.

fixes: #1187

Test

(Required) List the steps to test the behavior. For example:

Nothing specific here, but we want to test the new auth views so, try and consider this list of things:

  1. Load through the different views in the auth process and make sure that going back and forth between views to ensure it looks right and the animations are solid
  2. Attempt a sign up
  3. Attempt login with code. While testing code login, try entering bad codes and expired codes
  4. Attempt login with email link. Also test an expired link
  5. Attempt login with password
  6. Make sure that if you put invalid values in the different text fields that you are given an error

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:
Doesn't require updates because it is already there

charliescheer and others added 30 commits July 22, 2024 16:08
@charliescheer charliescheer added the [feature] login Anything relating to login label Jul 26, 2024
@charliescheer charliescheer added this to the 2.21 milestone Jul 26, 2024
@charliescheer charliescheer self-assigned this Jul 26, 2024
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@roundhill
Copy link
Contributor

You shall not pass… invalid login attempts!

@roundhill
Copy link
Contributor

(Can be in follow-up PR)

There's just a few capitalization issues that don't match the Figma:

  • On the code entry screen change the button label from Log In to Log in
  • Same thing on the password entry screen
  • On the password entry screen, Change Forgot your Password? to Forgot your password?
  • ... and any others I may have missed :D

Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the steps and it worked great! Noted a few copy changes that can be added later, or here if you want!

GO MAGIC LINKS!

@charliescheer charliescheer merged commit 28c7485 into trunk Jul 26, 2024
8 checks passed
@charliescheer charliescheer deleted the feature/1187-magic-links branch July 26, 2024 21:31
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Auth works super
✅ Password Auth also works
✅ Signup is also good, just confirmed
✅ Rate Limited Login handled
✅ Invalid Code error, also, handled
✅ Transitions look super smooth, no Layout constraint errors onscreen
✅ Signup validation(s) also look good
✅ First Responder management also looks good, when you go back / forwards

Nice work Charlie!!

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[feature] login Anything relating to login
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magic Links: Switch to Code Authentication
4 participants