-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated AppIcon assets to work with new ios 18 styles #1660
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
142 changes: 2 additions & 140 deletions
142
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,147 +1,9 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "2x", | ||
| "size" : "20x20" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "3x", | ||
| "size" : "20x20" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-29x29-1.png", | ||
| "idiom" : "iphone", | ||
| "scale" : "1x", | ||
| "size" : "29x29" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "2x", | ||
| "size" : "29x29" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "3x", | ||
| "size" : "29x29" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "2x", | ||
| "size" : "40x40" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "3x", | ||
| "size" : "40x40" | ||
| }, | ||
| { | ||
| "idiom" : "iphone", | ||
| "scale" : "1x", | ||
| "size" : "57x57" | ||
| }, | ||
| { | ||
| "idiom" : "iphone", | ||
| "scale" : "2x", | ||
| "size" : "57x57" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "2x", | ||
| "size" : "60x60" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "3x", | ||
| "size" : "60x60" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-20x20.png", | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "20x20" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "20x20" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-29x29.png", | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "29x29" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "29x29" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-40x40.png", | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "40x40" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "40x40" | ||
| }, | ||
| { | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "50x50" | ||
| }, | ||
| { | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "50x50" | ||
| }, | ||
| { | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "72x72" | ||
| }, | ||
| { | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "72x72" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-76x76.png", | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "76x76" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "76x76" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "83.5x83.5" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-iTunes.png", | ||
| "idiom" : "ios-marketing", | ||
| "scale" : "1x", | ||
| "idiom" : "universal", | ||
| "platform" : "ios", | ||
| "size" : "1024x1024" | ||
| } | ||
| ], | ||
|
|
||
Binary file removed
BIN
-1.61 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/Icon-App-20x20.png
Binary file not shown.
Binary file removed
BIN
-1.21 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/[email protected]
Binary file not shown.
Binary file removed
BIN
-1.21 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/[email protected]
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-921 Bytes
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/Icon-App-29x29-1.png
Binary file not shown.
Binary file removed
BIN
-921 Bytes
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/Icon-App-29x29.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-5.34 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/[email protected]
Binary file not shown.
Binary file removed
BIN
-1.21 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/Icon-App-40x40.png
Binary file not shown.
Binary file removed
BIN
-4.96 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/[email protected]
Binary file not shown.
Binary file removed
BIN
-2.25 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/[email protected]
Binary file not shown.
Binary file removed
BIN
-8.02 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/[email protected]
Binary file not shown.
Binary file removed
BIN
-8.02 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/[email protected]
Binary file not shown.
Binary file removed
BIN
-10.8 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/[email protected]
Binary file not shown.
Binary file removed
BIN
-2.15 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/Icon-App-76x76.png
Binary file not shown.
Binary file removed
BIN
-8.83 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/[email protected]
Binary file not shown.
Binary file removed
BIN
-9.95 KB
Simplenote/Icons.xcassets/AppIcon-Beta.appiconset/[email protected]
Binary file not shown.
132 changes: 2 additions & 130 deletions
132
Simplenote/Icons.xcassets/AppIcon.appiconset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,137 +1,9 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "2x", | ||
| "size" : "20x20" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "3x", | ||
| "size" : "20x20" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-29x29.png", | ||
| "idiom" : "iphone", | ||
| "scale" : "1x", | ||
| "size" : "29x29" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "2x", | ||
| "size" : "29x29" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "3x", | ||
| "size" : "29x29" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "2x", | ||
| "size" : "40x40" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "3x", | ||
| "size" : "40x40" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "2x", | ||
| "size" : "60x60" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "iphone", | ||
| "scale" : "3x", | ||
| "size" : "60x60" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-20x20.png", | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "20x20" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "20x20" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-29x29-1.png", | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "29x29" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "29x29" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-40x40.png", | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "40x40" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "40x40" | ||
| }, | ||
| { | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "50x50" | ||
| }, | ||
| { | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "50x50" | ||
| }, | ||
| { | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "72x72" | ||
| }, | ||
| { | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "72x72" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-76x76.png", | ||
| "idiom" : "ipad", | ||
| "scale" : "1x", | ||
| "size" : "76x76" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "76x76" | ||
| }, | ||
| { | ||
| "filename" : "[email protected]", | ||
| "idiom" : "ipad", | ||
| "scale" : "2x", | ||
| "size" : "83.5x83.5" | ||
| }, | ||
| { | ||
| "filename" : "Icon-App-iTunes.png", | ||
| "idiom" : "ios-marketing", | ||
| "scale" : "1x", | ||
| "idiom" : "universal", | ||
| "platform" : "ios", | ||
| "size" : "1024x1024" | ||
| } | ||
| ], | ||
|
|
||
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-915 Bytes
Simplenote/Icons.xcassets/AppIcon.appiconset/Icon-App-29x29-1.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the app icons we had created were just too old to be compatible with the new appearance stuff. By giving it a full size 1024x1024 only and allowing Xcode/iOS to generate all the other sizes it fixed the issue. For some reason this wasn't required for the sustainer icon to work 🤷 maybe that was new enough that it was fine