-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated AppIcon assets to work with new ios 18 styles #1660
Conversation
{ | ||
"filename" : "Icon-App-iTunes.png", | ||
"idiom" : "ios-marketing", | ||
"scale" : "1x", | ||
"idiom" : "universal", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the app icons we had created were just too old to be compatible with the new appearance stuff. By giving it a full size 1024x1024 only and allowing Xcode/iOS to generate all the other sizes it fixed the issue. For some reason this wasn't required for the sustainer icon to work 🤷 maybe that was new enough that it was fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Love the file cleanup. It looks great on iOS 18 in all the modes, and still looks fine on iOS 17. Thank you Charlie!
📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
|
Fix
In iOS 18 we are given the ability to customize the look of app icons on our Home Screen. The app icons should be able to respond to light mode, dark mode, and custom schemes. For some reason the
AppIcon
and theAppIcon-Beta
icons were not compatible with this new feature, but theAppIcon-Sustainer
was.So in this PR I have updated the
AppIcon
andAppIcon-Beta
to work with the new Home Screen customizations.fixes #1658
Test
AppIcon-Beta
toAppIcon
Review
(Required) Add instructions for reviewers. For example:
Release
(Required) Add a concise statement to
RELEASE-NOTES.txt
if the changes should be included in release notes. Include details about updating the notes in this section. For example:If the changes should not be included in release notes, add a statement to this section. For example: