Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AppIcon assets to work with new ios 18 styles #1660

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

charliescheer
Copy link
Contributor

@charliescheer charliescheer commented Sep 13, 2024

Fix

In iOS 18 we are given the ability to customize the look of app icons on our Home Screen. The app icons should be able to respond to light mode, dark mode, and custom schemes. For some reason the AppIcon and the AppIcon-Beta icons were not compatible with this new feature, but the AppIcon-Sustainer was.

So in this PR I have updated the AppIcon and AppIcon-Beta to work with the new Home Screen customizations.

fixes #1658

Test

  1. Launch Simplenote from Xcode. Must be running the iOS 18 Beta, so you will need an Xcode beta to test this
  2. After the app launches go to the Home Screen, long press on the background and then tap Edit > customize.
  3. Try all of the following settings and make sure the app icon updates to the correct theme:
  • Small - Light
  • Small - Dark
  • Small -Automatic
  • Small - Tinted
  • Large - Light
  • Large - Dark
  • Large -Automatic
  • Large - Tinted
  1. In Xcode go to the project navigator and select the Simplenote target > General. Scroll down to App Icon and Home Screen.
  2. Next to App Icon tap on the three dots and find Debug. Change the value from AppIcon-Beta to AppIcon
  3. Repeat steps 1-3 for the release app icon

Review

(Required) Add instructions for reviewers. For example:

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

RELEASE-NOTES.txt was updated in d3adb3ef with:

Added markdown support

If the changes should not be included in release notes, add a statement to this section. For example:

These changes do not require release notes.

@charliescheer charliescheer added the debt Technical debt. label Sep 13, 2024
@charliescheer charliescheer added this to the 4.54 milestone Sep 13, 2024
@charliescheer charliescheer self-assigned this Sep 13, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 4.54. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

{
"filename" : "Icon-App-iTunes.png",
"idiom" : "ios-marketing",
"scale" : "1x",
"idiom" : "universal",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the app icons we had created were just too old to be compatible with the new appearance stuff. By giving it a full size 1024x1024 only and allowing Xcode/iOS to generate all the other sizes it fixed the issue. For some reason this wasn't required for the sustainer icon to work 🤷 maybe that was new enough that it was fine

Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Love the file cleanup. It looks great on iOS 18 in all the modes, and still looks fine on iOS 17. Thank you Charlie!

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 14, 2024

Simplenote Prototype Build📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
App NameSimplenote Prototype Build Simplenote Prototype Build
Build Numberpr1660-d52df74-0191ee7a-a04a-426a-822b-683b3b57f59e
Version4.53
Bundle IDcom.codality.NotationalFlow.Alpha
Commitd52df74
App Center BuildSimplenote - Installable Builds #378
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@charliescheer charliescheer merged commit 6da24bd into trunk Sep 14, 2024
9 checks passed
@charliescheer charliescheer deleted the charlie/prepare-icons-for-ios18-mk2 branch September 14, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add iOS 18 Dark Icon
4 participants