Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make method to trigger Buildkite build annotate the caller #1653

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Make method to trigger Buildkite build annotate the caller #1653

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27f7fe6
Remove outdated comment from `start-code-freeze.yml`
mokagio Sep 4, 2024
08c75e9
Make method to trigger Buildkite build annotate the caller, if any
mokagio Sep 4, 2024
46134a3
Store `build_url` before using it -.-'
mokagio Sep 6, 2024
439bc6c
Reword a release notes commit message and fix a typo
mokagio Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .buildkite/release-pipelines/start-code-freeze.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ steps:
- label: Start Code Freeze
plugins:
- $CI_TOOLKIT_PLUGIN
# The first client to implement releases in CI was Android so the automation works in that queue.
# We might want to move it to a leaner one in the future.
agents:
queue: tumblr-metal
command: |
Expand Down
5 changes: 5 additions & 0 deletions fastlane/lanes/release.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,11 @@ def trigger_buildkite_release_build(branch:, beta:)
environment: { BETA_RELEASE: beta },
pipeline_file: 'release-build.yml'
)

return unless is_ci

message = "This build triggered #{build_url} on <code>#{branch}</code>."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build_url variable is not defined here. You need to update line 251 to build_url = buildkite_trigger_build(…) too for this to be defined 😉

buildkite_annotate(style: 'info', context: 'trigger-release-build', message: message)
end

def create_release_backmerge_pr(version_to_merge:, next_version:)
Expand Down