Make method to trigger Buildkite build annotate the caller #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Spencer Transier <[email protected]>
Generated by 🚫 Danger |
mokagio
added
tooling
|
| App Name |  Simplenote Prototype Build |
|
| Build Number | pr1653-439bc6c-0191c5f6-c52f-4d66-806d-3b117e2801c6 | |
| Version | 4.53 | |
| Bundle ID | com.codality.NotationalFlow.Alpha | |
| Commit | 439bc6c | |
| App Center Build | Simplenote - Installable Builds #361 |
AliSoftware
requested changes
Sep 4, 2024
|
|
||
| return unless is_ci | ||
|
|
||
| message = "This build triggered #{build_url} on <code>#{branch}</code>." |
There was a problem hiding this comment.
build_url variable is not defined here. You need to update line 251 to build_url = buildkite_trigger_build(…) too for this to be defined 😉
Co-authored-by: Olivier Halligon <[email protected]>
Co-authored-by: Olivier Halligon <[email protected]>
AliSoftware
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup to the work in #1646 #1649 #1650, where to implement any code review feedback or fix for issues discovered found in the process.
I'll update the title accordingly before merging, for the moment, there is only one meaningful change to report.
Review
Only one infra engineer required to review these changes, but anyone can perform the review.
Release
These changes do not require release notes.