Moved isolate select scene index creation to avoid losing isolate sel… #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Nov 6, 2024
| @@ -1096,6 +1096,22 @@ void MtohRenderOverride::_InitHydraResources(const MHWRender::MDrawContext& draw | |||
| _dirtyLeadObjectSceneIndex = MAYAHYDRA_NS::MhDirtyLeadObjectSceneIndex::New(_inputSceneIndexOfFilteringSceneIndicesChain); | |||
| _inputSceneIndexOfFilteringSceneIndicesChain = _dirtyLeadObjectSceneIndex; | |||
|
|
|||
| #ifdef MAYA_HAS_VIEW_SELECTED_OBJECT_API | |||
There was a problem hiding this comment.
Moved from _CreateSceneIndicesChainAfterMergingSceneIndex(). The isolate select scene index is independent of display style and therefore does not need to be re-created on shading change (e.g. bounding box mode).
There was a problem hiding this comment.
Without the fix, the test fails. With the fix, the test passes.
lanierd-adsk
approved these changes
Nov 7, 2024
ppt-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ection.