Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code coverage build issue #104

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Conversation

roopavr-adsk
Copy link
Contributor

@roopavr-adsk roopavr-adsk commented Mar 19, 2024

Change in this PR:

  1. previous code in renderOverride.cpp has a unique_ptr's method function release(). Since our codebase cleanup, we changed the type of MayaHydraSceneIndex to Pixar's internal counted ref pointer. The equivalent method seems to be to use Reset()
  2. Remove a spurious export/import on a member function which seems to be a relic and an uncaught bug.
  3. Exclude PDB generation for a example code.

@roopavr-adsk roopavr-adsk requested a review from ppt-adsk March 19, 2024 20:25
@roopavr-adsk roopavr-adsk added bug Something isn't working ready-for-merge Development process is finished, PR is ready for merge labels Mar 19, 2024
@roopavr-adsk roopavr-adsk merged commit 59b9563 into dev Mar 19, 2024
10 of 11 checks passed
@roopavr-adsk roopavr-adsk deleted the roopavr/fixCodeCoverageBuildIssue branch March 19, 2024 21:17
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants