Fix code coverage build issue (#104)

* Fix build isses when running code coverage * Update CMakeLists to exclude pdb when running code coverage
Autodesk · Mar 19, 2024 · 59b9563 · 59b9563
1 parent b4d88c6
commit 59b9563
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/mayaHydra/flowViewportAPIExamples/footPrintNode/CMakeLists.txt b/lib/mayaHydra/flowViewportAPIExamples/footPrintNode/CMakeLists.txt
@@ -88,8 +88,10 @@ install(TARGETS ${TARGET_NAME}
         DESTINATION ${CMAKE_INSTALL_PREFIX}/lib/maya)
 
 if(IS_WINDOWS)
-    install(FILES $<TARGET_PDB_FILE:${TARGET_NAME}> 
-            DESTINATION ${CMAKE_INSTALL_PREFIX}/lib/maya OPTIONAL)
+    if (NOT CODE_COVERAGE)
+        install(FILES $<TARGET_PDB_FILE:${TARGET_NAME}> 
+                DESTINATION ${CMAKE_INSTALL_PREFIX}/lib/maya OPTIONAL)    
+    endif()                
 endif()
 
 set(LIBFILENAME ${CMAKE_SHARED_LIBRARY_PREFIX}${TARGET_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX})

diff --git a/lib/mayaHydra/mayaPlugin/renderOverride.cpp b/lib/mayaHydra/mayaPlugin/renderOverride.cpp
@@ -888,7 +888,7 @@ void MtohRenderOverride::ClearHydraResources(bool fullReset)
         // Leak the Maya scene index, as its base class HdRetainedSceneIndex
         // destructor crashes under Windows clang code coverage build.
         _mayaHydraSceneIndex->RemoveCallbacksAndDeleteAdapters();
-        _mayaHydraSceneIndex.release();
+        _mayaHydraSceneIndex.Reset();
     #else
        _ClearMayaHydraSceneIndex();
     #endif

diff --git a/lib/mayaHydra/mayaPlugin/renderOverride.h b/lib/mayaHydra/mayaPlugin/renderOverride.h
@@ -179,7 +179,6 @@ class MtohRenderOverride : public MHWRender::MRenderOverride
             [&panelName](const PanelCallbacks& item) { return item.first == panelName; });
     }
 
-    MAYAHYDRALIB_API
     void _PopulateSelectionList(
         const HdxPickHitVector&          hits,
         const MHWRender::MSelectionInfo& selectInfo,