Report build and version information from the mayaHydra plugin #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Nov 13, 2023
| @@ -146,6 +147,10 @@ set(SRCFILE ${CMAKE_CURRENT_SOURCE_DIR}/mayaHydra.h.src) | |||
| set(DSTFILE ${CMAKE_BINARY_DIR}/include/mayaHydraLib/mayaHydra.h) | |||
| configure_file(${SRCFILE} ${DSTFILE}) | |||
|
|
|||
| set(SRCFILE ${CMAKE_CURRENT_SOURCE_DIR}/mhBuildInfo.h.src) | |||
There was a problem hiding this comment.
Configure the build information file so that it gets build and version information.
| @@ -47,20 +47,16 @@ | |||
| #error Maya API version 2024+ required | |||
There was a problem hiding this comment.
Fixed namespacing.
| constexpr auto _pluginInfoCutId = "-cid"; | ||
| constexpr auto _pluginInfoCutIdLong = "-pluginInfoCut"; | ||
| // Versioning and build information. | ||
| constexpr auto _majorVersion = "-mjv"; |
There was a problem hiding this comment.
Core file in the review: add flags to the mayaHydra command to get version and build information.
roopavr-adsk
approved these changes
Nov 16, 2023
ppt-adsk
added
the
ready-for-merge
roopavr-adsk
deleted the
tremblp/HYDRA-491/report_peptide_info_github
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly understand and test a given version of the mayaHydra plugin, it must be possible to report its build and version information from a command in the plugin.