Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-1024 - Provide a mechanism to retrieve an unambigous version f… #3639

Merged

Conversation

seando-adsk
Copy link
Collaborator

EMSUSD-1024 - Provide a mechanism to retrieve an unambigous version for mayaUSD

  • To properly understand and test a given version of the MayaUsd plugin, it must be possible to report its build and version information from a command in the plugin.

…or mayaUSD

* To properly understand and test a given version of the MayaUsd plugin,
  it must be possible to report its build and version information from
  a command in the plugin.
@seando-adsk
Copy link
Collaborator Author

This is heavily based on previous work done in the maya-hydra repro in PR Autodesk/maya-hydra#10
I changed a couple of things (after taking with PierreT). He will make changes to their version to match ours.

CMakeLists.txt Show resolved Hide resolved
cmake/utils.cmake Show resolved Hide resolved
plugin/adsk/plugin/plugin.cpp Show resolved Hide resolved
@AramAzhari-adsk AramAzhari-adsk self-requested a review March 13, 2024 14:48
Copy link
Collaborator

@AramAzhari-adsk AramAzhari-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! It will make tracking issues to the exact build numbers much easier.

Thank you for doing this.

@seando-adsk seando-adsk self-assigned this Mar 19, 2024
@seando-adsk seando-adsk added the adsk Related to Autodesk plugin label Mar 19, 2024
@seando-adsk
Copy link
Collaborator Author

One random test failure on extra config job with test "testVP2RenderDelegatePerInstanceInheritedData". Marking as ready for merge.

@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Mar 19, 2024
@seando-adsk seando-adsk merged commit 9ee0a00 into dev Mar 19, 2024
10 of 11 checks passed
@seando-adsk seando-adsk deleted the donnels/EMSUSD-1024/new_command_to_report_build_info branch March 19, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adsk Related to Autodesk plugin ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants