Load models from huggingface instead of blob storage #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 3 3
Lines 120 120
=======================================
Hits 115 115
Misses 5 5 ☔ View full report in Codecov by Sentry. |
lsetiawan
reviewed
Jan 5, 2024
lsetiawan
requested changes
Jan 5, 2024
|
I agree with @lsetiawan Everything looks good, just take a look at the PyPI publishing. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 3 3
Lines 120 120
=======================================
Hits 115 115
Misses 5 5 ☔ View full report in Codecov by Sentry. |
lsetiawan
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During test I found loading models from the HuggingFace hub is faster, likely due to additional optimization/parallel loading vs loading from blob storage mounted as a file system. This always simplifies testing different models since they don't need to be copied over to blob storage first.
Some opportunistic/small changes too.