Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Workflow now checks more OS #64

Merged
merged 38 commits into from
Sep 26, 2023
Merged

feat: Workflow now checks more OS #64

merged 38 commits into from
Sep 26, 2023

Conversation

Poiuy7312
Copy link
Collaborator

Previously the workflow only ran on Linux but now it should run on Linux, MacOS and Windows making it easier to make sure chasten is running properly on all major platforms.

Poiuy7312 and others added 30 commits September 15, 2023 10:42
@Poiuy7312
Tried using a os matrix like I saw in gatorgrade
79a1155
@Poiuy7312
Edited workflow
58d4481
@Poiuy7312
Checking Error
11d3530
@Poiuy7312
added bracnh to workflow
d7a3f5a
@Poiuy7312
Removed python 3.10 from ubuntu. Added conditional
8f6e44a
@Poiuy7312
Update poetry.lock
30340ab
@Poiuy7312
Update pyproject.toml
a2f00a4
@Poiuy7312
got rid of special character in main.py
1060f63
@Poiuy7312
Update main.py
dd40f83 
Removed special character to see if its messing with workflow
@Poiuy7312
Update main.py
83105fb
@Poiuy7312
Removed pysqlite3
0bde930
@Poiuy7312
Merge branch 'Work-flow-changes-to-check-more-OS' of github.com:Astut…
6c52e57 
…eSource/chasten into Work-flow-changes-to-check-more-OS
@Poiuy7312
trying to change windows encoding
ebf14f4
@Poiuy7312
Trying a different approach to change encoding
bdf6ba3
@Poiuy7312
Encoding Windows
3bcd345
@Poiuy7312
Removed Special characters
fa53f10
@Poiuy7312
Removed sparkles
d489d23
@Poiuy7312
Removed characters
6691550
@Poiuy7312
Added special character back
b247a41
@Poiuy7312
Reformatted Main.py
0bd58bd
@Poiuy7312
style: changed chasten.emoji in constants.py to *
6a8acd9
@Poiuy7312
style: removed link character from constants.py
bb21175
@Poiuy7312
style: removed ✨ from main.py
2505ec1
@Poiuy7312
style: removed special characters from main.py
18e4190
@Poiuy7312
style: got rid of checkmarks in util.py
3703e4f
@Poiuy7312
style: removed emoji in main.py
2394e39
@Poiuy7312
style: added special character back to main.py
58ca98f
@Poiuy7312
style: Added special characters back
92815b1
@Poiuy7312
style: added special characters back to util.py
23fff71
@Poiuy7312
fix: trying to change encoding for workflow.
9004f84
@Poiuy7312 Poiuy7312 self-assigned this Sep 20, 2023
@Poiuy7312 Poiuy7312 changed the title Workflow now checks more OS feat: Workflow now checks more OS Sep 20, 2023
@Poiuy7312 Poiuy7312 added infrastructure Docker and CI/CD setup and/or configuration and removed infrastructure Docker and CI/CD setup and/or configuration in-progress Work is actively happening on this issue labels Sep 20, 2023
@jnormile
Copy link
Collaborator

Adding @AidanNeeson as a reviewer; he'll be interested in the changes to CI/CD workflow.

@Poiuy7312 Poiuy7312 added this to the Week 5 Features milestone Sep 21, 2023
@Poiuy7312 Poiuy7312 linked an issue Sep 21, 2023 that may be closed by this pull request
Github Actions needs to check more then just Linux #61
Closed
@Poiuy7312 Poiuy7312 added the ready-for-review This pull request is ready for review label Sep 22, 2023
AidanNeeson
AidanNeeson previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@AidanNeeson AidanNeeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new workflow looks great to me! Awesome job implementing the other two operating systems. This will surely help us moving forward.

@gkapfham gkapfham added the enhancement New feature or request label Sep 22, 2023
@Poiuy7312 Poiuy7312 linked an issue Sep 25, 2023 that may be closed by this pull request
Improve GitHub Actions Configuration #10
Closed
laurennevill
laurennevill previously approved these changes Sep 25, 2023
View reviewed changes
@Poiuy7312 Poiuy7312 dismissed stale reviews from laurennevill and AidanNeeson via 50b4bdd September 26, 2023 18:47
@EvanNelson04 EvanNelson04 self-requested a review September 26, 2023 19:18
EvanNelson04
EvanNelson04 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@EvanNelson04 EvanNelson04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good to me

laurennevill
laurennevill approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@laurennevill laurennevill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for your work, @Poiuy7312

@boulais01 boulais01 self-requested a review September 26, 2023 19:25
@Poiuy7312 Poiuy7312 merged commit af27231 into master Sep 26, 2023
3 checks passed
@Poiuy7312 Poiuy7312 deleted the Work-flow-changes-to-check-more-OS branch September 26, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanNelson04 EvanNelson04 EvanNelson04 approved these changes

@boulais01 boulais01 boulais01 approved these changes

@laurennevill laurennevill laurennevill approved these changes

@AidanNeeson AidanNeeson AidanNeeson left review comments

@gkapfham gkapfham Awaiting requested review from gkapfham

@tuduun tuduun Awaiting requested review from tuduun

@jnormile jnormile Awaiting requested review from jnormile

Assignees

@Poiuy7312 Poiuy7312

Labels
enhancement New feature or request infrastructure Docker and CI/CD setup and/or configuration ready-for-review This pull request is ready for review
Projects
None yet
Milestone
Week 5 Features
Development

Successfully merging this pull request may close these issues.

Github Actions needs to check more then just Linux Improve GitHub Actions Configuration
7 participants
@Poiuy7312 @gkapfham @jnormile @AidanNeeson @laurennevill @boulais01 @EvanNelson04