-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic version update #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure how twine
works when it comes to building a package, I cannot seem to locate where it is capturing all of the projects dependencies. I would much rather an approach that uses poetry
the tool we are already using. There are commands that are a part of poetry that can assist with this issue, I would recommend looking there. For example, the command poetry version
will bump the version number in the toml to a specified number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the workflow a lot simpler. Extra steps could be taken to see consistency with the version number listed in the toml and what is on PyPI, but I think this is a good first step at making sure releases can be done consistently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this looks good
When creating a pull request to add a new feature or alter an existing one,
there are some important elements to include to help our team review and process it more efficiently.
Make sure the title is descriptive of what the PR includes. Don't mention issue names/numbers; save that for the description.
Automating push to PyPi.
List the names of those who contributed to the project.
@VitalJoseph , @KellerLiptrap , @MilesF25 , @Poiuy7312, @boulais01
Link the issue the pull request is meant to fix/resolve.
Automate Version Updates For PyPi #80
Describe the contents and goal of the pull request.
The goal is to be able to automate pushing to PyPi
Maintained
None
Mark as a draft until it is ready to begin the reviewing process, then tag our Lead Software Architect, Lauren Nevill,
our Principal Software Engineer, Bergas Batara, and our Founding Engineer, Gregory Kapfhammer
when you mark it as ready for review.