Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Version Updates For PyPi #80

Closed
boulais01 opened this issue Sep 29, 2023 · 6 comments · Fixed by #126
Closed

Automate Version Updates For PyPi #80

boulais01 opened this issue Sep 29, 2023 · 6 comments · Fixed by #126
Assignees
Labels
enhancement New feature or request

Comments

@boulais01
Copy link
Collaborator

The current problem is that version updates to the .toml must be made manually.

Ideally, this can be automated, although it is said this will make the publish.yml file a little more complicated, I expect the tradeoff will be worth it in the long run.

@boulais01
Copy link
Collaborator Author

@VitalJoseph @KellerLiptrap Have you made any progress on this? Remember that @MilesF25 and @AidanNeeson have some experience with this.

@simojo simojo added this to the Week 15 Features milestone Nov 28, 2023
@Poiuy7312 Poiuy7312 self-assigned this Nov 28, 2023
@MilesF25 MilesF25 self-assigned this Dec 4, 2023
@Poiuy7312 Poiuy7312 added the enhancement New feature or request label Dec 5, 2023
@boulais01
Copy link
Collaborator Author

@boulais01
Copy link
Collaborator Author

Please give a progress update on this before 5pm today, as the goal was for this to be done at 2:30pm today.

@MilesF25
Copy link
Collaborator

MilesF25 commented Dec 6, 2023

I added code for the automation but I'm not sure how to test without trying to push to PyPi. Would it be better to test pushing with this branch or should we merge then test?

@boulais01
Copy link
Collaborator Author

That is an excellent question, @MilesF25. Perhaps we can get some input from @AidanNeeson and @gkapfham on the best course of action here?

@AidanNeeson
Copy link
Collaborator

AidanNeeson commented Dec 11, 2023

@boulais01 or @MilesF25, could we open a pull request for the branch that contains these changes? It would be better to have a discussion there, as I have a few comments and questions coming from what I looked at. Thanks!

@MilesF25 MilesF25 linked a pull request Dec 12, 2023 that will close this issue
@KellerLiptrap KellerLiptrap removed their assignment Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants