-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Receipt UI #53
Merged
Merged
Receipt UI #53
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ca31b26
build: material 3
SidonieBouthors 4421d5c
Merge branch 'main' into ui/receipt-flow
SidonieBouthors f77b8c5
feat: add date picker with dialog
SidonieBouthors f3619cc
feat: add receipt route and basic screen
SidonieBouthors c385904
feat: update datepicker and add external modifier
SidonieBouthors 66c0066
feat: receipt screen layout and test tags
SidonieBouthors 4a08180
test: receipt screen display and back
SidonieBouthors ceda9fb
style: ktfmt format
SidonieBouthors d75838a
refactor: remove or comment unused items
SidonieBouthors c1b350a
test: date picker
SidonieBouthors File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
app/src/androidTest/java/com/github/se/assocify/screens/ReceiptScreenTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
package com.github.se.assocify.screens | ||
|
||
import androidx.compose.ui.test.assertIsDisplayed | ||
import androidx.compose.ui.test.junit4.createComposeRule | ||
import androidx.compose.ui.test.onNodeWithTag | ||
import androidx.compose.ui.test.performClick | ||
import androidx.test.ext.junit.runners.AndroidJUnit4 | ||
import com.github.se.assocify.navigation.NavigationActions | ||
import com.github.se.assocify.ui.screens.treasury.receipt.ReceiptScreen | ||
import com.kaspersky.components.composesupport.config.withComposeSupport | ||
import com.kaspersky.kaspresso.kaspresso.Kaspresso | ||
import com.kaspersky.kaspresso.testcases.api.testcase.TestCase | ||
import io.mockk.every | ||
import io.mockk.mockk | ||
import org.junit.Before | ||
import org.junit.Rule | ||
import org.junit.Test | ||
import org.junit.runner.RunWith | ||
|
||
@RunWith(AndroidJUnit4::class) | ||
class ReceiptScreenTest : TestCase(kaspressoBuilder = Kaspresso.Builder.withComposeSupport()) { | ||
@get:Rule val composeTestRule = createComposeRule() | ||
|
||
private val navActions = mockk<NavigationActions>() | ||
private var tabSelected = false | ||
|
||
@Before | ||
fun testSetup() { | ||
every { navActions.back() } answers { tabSelected = true } | ||
composeTestRule.setContent { ReceiptScreen(navActions = navActions) } | ||
} | ||
|
||
@Test | ||
fun display() { | ||
with(composeTestRule) { | ||
onNodeWithTag("receiptScreen").assertIsDisplayed() | ||
onNodeWithTag("titleField").assertIsDisplayed() | ||
onNodeWithTag("descriptionField").assertIsDisplayed() | ||
onNodeWithTag("dateField").assertIsDisplayed() | ||
onNodeWithTag("backButton").assertIsDisplayed() | ||
} | ||
} | ||
|
||
@Test | ||
fun back() { | ||
with(composeTestRule) { | ||
onNodeWithTag("backButton").performClick() | ||
assert(tabSelected) | ||
} | ||
} | ||
|
||
@Test | ||
fun datePicker() { | ||
with(composeTestRule) { | ||
onNodeWithTag("dateField").performClick() | ||
onNodeWithTag("datePickerDialog").assertIsDisplayed() | ||
onNodeWithTag("datePickerDialogDismiss").performClick() | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
app/src/main/java/com/github/se/assocify/ui/composables/DatePickerWithDialog.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
package com.github.se.assocify.ui.composables | ||
|
||
import androidx.compose.foundation.clickable | ||
import androidx.compose.foundation.layout.Box | ||
import androidx.compose.material3.Button | ||
import androidx.compose.material3.DatePicker | ||
import androidx.compose.material3.DatePickerDialog | ||
import androidx.compose.material3.ExperimentalMaterial3Api | ||
import androidx.compose.material3.OutlinedTextField | ||
import androidx.compose.material3.SelectableDates | ||
import androidx.compose.material3.Text | ||
import androidx.compose.material3.rememberDatePickerState | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.runtime.getValue | ||
import androidx.compose.runtime.mutableStateOf | ||
import androidx.compose.runtime.remember | ||
import androidx.compose.runtime.setValue | ||
import androidx.compose.ui.Modifier | ||
import androidx.compose.ui.draw.alpha | ||
import androidx.compose.ui.platform.testTag | ||
import java.time.Instant | ||
import java.time.LocalDate | ||
import java.time.ZoneId | ||
|
||
@OptIn(ExperimentalMaterial3Api::class) | ||
@Composable | ||
fun DatePickerWithDialog( | ||
modifier: Modifier = Modifier, | ||
label: @Composable () -> Unit, | ||
dateValue: String, | ||
onDateSelected: (LocalDate?) -> Unit | ||
) { | ||
var showDialog by remember { mutableStateOf(false) } | ||
val datePickerState = | ||
rememberDatePickerState( | ||
selectableDates = | ||
object : SelectableDates { | ||
override fun isSelectableDate(utcTimeMillis: Long): Boolean { | ||
return utcTimeMillis >= | ||
LocalDate.now() | ||
.atStartOfDay() | ||
.atZone(ZoneId.systemDefault()) | ||
.toInstant() | ||
.toEpochMilli() | ||
} | ||
}) | ||
val selectedDate = | ||
datePickerState.selectedDateMillis?.let { | ||
Instant.ofEpochMilli(it).atZone(ZoneId.systemDefault()).toLocalDate() | ||
} | ||
|
||
Box { | ||
OutlinedTextField( | ||
modifier = modifier, | ||
value = dateValue, | ||
onValueChange = {}, | ||
readOnly = true, | ||
label = { label() }, | ||
placeholder = { Text("--/--/--") }) | ||
Box(modifier = Modifier.matchParentSize().alpha(0f).clickable(onClick = { showDialog = true })) | ||
} | ||
|
||
if (showDialog) { | ||
DatePickerDialog( | ||
modifier = Modifier.testTag("datePickerDialog"), | ||
onDismissRequest = { showDialog = false }, | ||
confirmButton = { | ||
Button( | ||
onClick = { | ||
showDialog = false | ||
onDateSelected(selectedDate) | ||
}) { | ||
Text(text = "OK") | ||
} | ||
}, | ||
dismissButton = { | ||
Button( | ||
modifier = Modifier.testTag("datePickerDialogDismiss"), | ||
onClick = { showDialog = false }) { | ||
Text(text = "Cancel") | ||
} | ||
}) { | ||
DatePicker(state = datePickerState, showModeToggle = true) | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
app/src/main/java/com/github/se/assocify/ui/screens/treasury/receipt/ReceiptScreen.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
package com.github.se.assocify.ui.screens.treasury.receipt | ||
|
||
import androidx.compose.foundation.layout.fillMaxSize | ||
import androidx.compose.foundation.lazy.LazyColumn | ||
import androidx.compose.material.icons.Icons | ||
import androidx.compose.material.icons.filled.ArrowBack | ||
import androidx.compose.material3.ExperimentalMaterial3Api | ||
import androidx.compose.material3.Icon | ||
import androidx.compose.material3.IconButton | ||
import androidx.compose.material3.MediumTopAppBar | ||
import androidx.compose.material3.OutlinedTextField | ||
import androidx.compose.material3.Scaffold | ||
import androidx.compose.material3.Text | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.ui.Alignment | ||
import androidx.compose.ui.Modifier | ||
import androidx.compose.ui.platform.testTag | ||
import com.github.se.assocify.navigation.NavigationActions | ||
import com.github.se.assocify.ui.composables.DatePickerWithDialog | ||
|
||
@OptIn(ExperimentalMaterial3Api::class) | ||
@Composable | ||
fun ReceiptScreen(navActions: NavigationActions) { | ||
Scaffold( | ||
modifier = Modifier.testTag("receiptScreen"), | ||
topBar = { | ||
MediumTopAppBar( | ||
title = { Text("New Receipt") }, | ||
navigationIcon = { | ||
IconButton( | ||
modifier = Modifier.testTag("backButton"), onClick = { navActions.back() }) { | ||
Icon(Icons.Default.ArrowBack, contentDescription = "Back") | ||
} | ||
}) | ||
}, | ||
) { | ||
LazyColumn( | ||
modifier = Modifier.fillMaxSize(), | ||
contentPadding = it, | ||
horizontalAlignment = Alignment.CenterHorizontally) { | ||
item { | ||
OutlinedTextField( | ||
modifier = Modifier.testTag("titleField"), | ||
value = "", | ||
onValueChange = { /*TODO*/}, | ||
label = { Text("Title") }) | ||
OutlinedTextField( | ||
modifier = Modifier.testTag("descriptionField"), | ||
value = "", | ||
onValueChange = { /*TODO*/}, | ||
label = { Text("Description") }, | ||
minLines = 3) | ||
DatePickerWithDialog( | ||
modifier = Modifier.testTag("dateField"), | ||
label = { Text("Date") }, | ||
dateValue = "", | ||
onDateSelected = { /*TODO*/}) | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,5 +35,7 @@ class NavigationActionsTest { | |
|
||
navActions.onAuthError() | ||
navActions.onLogin(user) | ||
|
||
navActions.back() | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional or did you forget to modify the TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to work well. I wrote a preview that seems to work as intended, the application still works as before and the test pass. However all the TODOS make it difficult to understand what was forgetten and what is expected to be finished in the next weeks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of them will be fixed next week when I do the functionality of this part and link things together. I'll make sure to double check that I fix all of them in my next PR :)