Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receipt UI #53

Merged
merged 10 commits into from
Apr 6, 2024
Merged

Receipt UI #53

merged 10 commits into from
Apr 6, 2024

Conversation

SidonieBouthors
Copy link
Member

@SidonieBouthors SidonieBouthors commented Mar 28, 2024

  • Add basic structure of add receipt page
  • Add date picker

@SidonieBouthors SidonieBouthors self-assigned this Mar 28, 2024
@SidonieBouthors SidonieBouthors linked an issue Mar 28, 2024 that may be closed by this pull request
@SidonieBouthors SidonieBouthors marked this pull request as draft April 3, 2024 19:10
@SidonieBouthors SidonieBouthors changed the title Receipt flow Receipt UI Apr 6, 2024
Copy link

sonarcloud bot commented Apr 6, 2024

@SidonieBouthors
Copy link
Member Author

This is a pretty basic start with a layout and a date picker. I'll be working more on adding the camera and some functionality next sprint but I think we can merge this as a start for now

@SidonieBouthors SidonieBouthors marked this pull request as ready for review April 6, 2024 12:29
Copy link
Contributor

@ortolino ortolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR seems to work well, the app works as before and the new modifications seem to work as well.

@@ -24,4 +24,8 @@ class NavigationActions(private val navController: NavHostController) {
fun onAuthError() {
/* Handle auth error */
}

fun back() {
/*TODO handle back navigation*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional or did you forget to modify the TODO?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work well. I wrote a preview that seems to work as intended, the application still works as before and the test pass. However all the TODOS make it difficult to understand what was forgetten and what is expected to be finished in the next weeks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of them will be fixed next week when I do the functionality of this part and link things together. I'll make sure to double check that I fix all of them in my next PR :)

@SidonieBouthors SidonieBouthors merged commit 512d026 into main Apr 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add New Receipt UI
2 participants