-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 32 motors, including dodecahexa-octa (two-layers of 8 motors each) #29020
Open
peterbarker
wants to merge
22
commits into
ArduPilot:master
Choose a base branch
from
peterbarker:pr/muramura/AP_Support_HexadecaOcta_OCTA_X16
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for 32 motors, including dodecahexa-octa (two-layers of 8 motors each) #29020
peterbarker
wants to merge
22
commits into
ArduPilot:master
from
peterbarker:pr/muramura/AP_Support_HexadecaOcta_OCTA_X16
+353
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/muramura/AP_Support_HexadecaOcta_OCTA_X16
branch
from
January 8, 2025 05:24
b4e4c88
to
4b2cdc7
Compare
I've removed a patch which did this:
.... it was killing various autotests. |
|
a stack of 8 X quad frames
Co-authored-by: muramura <[email protected]>
this allows MotorMatrix to change a channel's default (and value) from k_GPIO to a motor output value. The loop in the SRV_Channels contructors sets all defaults for channels above 16 to GPIO, and this code stopped MotorsMatrix from assigning a different role the the output.
peterbarker
force-pushed
the
pr/muramura/AP_Support_HexadecaOcta_OCTA_X16
branch
from
January 8, 2025 23:24
4b2cdc7
to
77bdea9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a mashup of two other PRs which conflicted with one another.
tridge's PR (#27598) added 32-rotor support and a half-baked "m32" SITL frame to test it. I've completed the work on the 32-motor demo frame.
@muramura 's PR (#21157) added support for the 16-motor decahexa frame. It also modified ArduPilot to support 16 motors, which was a subset of tridge's 32-motor support, 'though remembered to patch AP_Periph to match the rest of ArduPilot.
I've reworked both sets of patches significantly to create this combined set, notably trying to bring consistency to the naming of files and frames.
Replaces #21157
Replaces #27598
Both new frames are flown in our "FlyEachFrame" test successfully.