Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle auto refuel #464

Closed
wants to merge 197 commits into from
Closed

Vehicle auto refuel #464

wants to merge 197 commits into from

Conversation

kingarthur91
Copy link
Collaborator

adds the abilty for angels burner gen to auto refuel from the cars inventory

LovelySanta and others added 30 commits November 4, 2020 19:08
fixed insert code to put as much as possible into the vehicle
* Rework lights for casting-machine and induction-furnace

* Rework blast-furnace lighting, move draw_as properties into animation definition in anticipation of deprecation within working vis

* Revamp strand casting machine working light, add fadeout

* Rework sintering-oven lights

* Fix wrong height for cooling tower in normal resolution

* Rework chemical furnace lights
Commits by @kirazy
Copy link
Collaborator

@LovelySanta LovelySanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if the indentation would be left with 2 spaces instead of 4, mainly for consistency, but also allows for a quicker review of the changes...

@kingarthur91
Copy link
Collaborator Author

Would be nice if the indentation would be left with 2 spaces instead of 4, mainly for consistency, but also allows for a quicker review of the changes...

sorry auto formatting script in vscode likes to sometimes "fix" indentations.

@Pezzawinkle
Copy link
Collaborator

either im getting an odd bug, or this PR is based in 1.0?

kingarthur91 and others added 4 commits April 6, 2021 22:27
fixed insert code to put as much as possible into the vehicle
spacing
"item stack count" back to 3 to match fuel slots in burners (was throwing an error on trying to add more fuel than slots).
@Pezzawinkle
Copy link
Collaborator

im sorry... the rebase seemed to have absolutely butchered the commit logs for this PR :(

if next(global.vehicle_burners) ~= nil then
for v, vehicle in pairs(global.vehicle_burners) do
local inv = vehicle.burner.burner.inventory.get_item_count()
if inv < 3 then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed this one to 3 since i was getting a crash on the 4th "grab"

)

script.on_nth_tick(
60,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we want to increase the tick count a bit higher but im fine with it now.
The thing to consider, is realistically, how many "stacks" of wood do we want to stick in per second?

Copy link
Collaborator

@Pezzawinkle Pezzawinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy for this to merge in with the minor modifications made as commented

@LovelySanta
Copy link
Collaborator

Closing this as 'duplicate' as #577 is a cleaned up version of this 'mess'

@LovelySanta LovelySanta closed this Apr 6, 2021
@Pezzawinkle Pezzawinkle deleted the vehicle-auto-refuel branch September 5, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants