Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignored state change #27

Closed
wants to merge 1 commit into from
Closed

fix: ignored state change #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions checks/check-state-changes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,6 @@ export const checkStateChanges: ProposalCheck = {
// mapping within a single `diff` element. We always JSON.stringify the values so structs
// (i.e. tuples) don't print as [object Object]
diffs.forEach((diff) => {
// Sometimes Tenderly will return state changes where the original value is null, which
// means the original and dirty (new) values are the same. This is currently a bug, but it
// only happens when the original and dirty values match (i.e. no storage was changed,
// because the slot went from original -> other value -> original). As a result we can
// safely skip these diffs.
if (diff.original === null) return

if (!diff.soltype) {
// In this branch, state change is not decoded, so return raw data of each storage write
// (all other branches have decoded state changes)
Expand Down