Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignored state change #27

Closed
wants to merge 1 commit into from
Closed

fix: ignored state change #27

wants to merge 1 commit into from

Conversation

gzeoneth
Copy link
Collaborator

Tenderly no longer return diff.original === null for storage slot that went from original -> other value -> original, but instead will have diff.original === null for undecoded slot. Removing the ignore to make sure seatbelt surface those storage changes.

Can test with #26
before

*   TransparentUpgradeableProxy at `0x1c479675ad559DC151F6Ec7ed3FbF8ceE79582B6`
    *   Slot `0x0000000000000000000000000000000000000000000000000000000000000004` changed from `"0x0000000000000000000000000000000000000000000000000000000000001680"` to `"0x0000000000000000000000000000000000000000000000000000000000000000"`
    *   Slot `0x0000000000000000000000000000000000000000000000000000000000000005` changed from `"0x000000000000000000000000000000000000000000000000000000000000000c"` to `"0x0000000000000000000000000000000000000000000000000000000000000000"`
    *   Slot `0x0000000000000000000000000000000000000000000000000000000000000006` changed from `"0x0000000000000000000000000000000000000000000000000000000000015180"` to `"0x0000000000000000000000000000000000000000000000000000000000000000"`
    *   Slot `0x0000000000000000000000000000000000000000000000000000000000000007` changed from `"0x0000000000000000000000000000000000000000000000000000000000000e10"` to `"0x0000000000000000000000000000000000000000000000000000000000000000"`

after

*   TransparentUpgradeableProxy at `0x1c479675ad559DC151F6Ec7ed3FbF8ceE79582B6`
    *   Slot `0x0000000000000000000000000000000000000000000000000000000000000004` changed from `"0x0000000000000000000000000000000000000000000000000000000000001680"` to `"0x0000000000000000000000000000000000000000000000000000000000000000"`
    *   Slot `0x0000000000000000000000000000000000000000000000000000000000000005` changed from `"0x000000000000000000000000000000000000000000000000000000000000000c"` to `"0x0000000000000000000000000000000000000000000000000000000000000000"`
    *   Slot `0x0000000000000000000000000000000000000000000000000000000000000006` changed from `"0x0000000000000000000000000000000000000000000000000000000000015180"` to `"0x0000000000000000000000000000000000000000000000000000000000000000"`
    *   Slot `0x0000000000000000000000000000000000000000000000000000000000000007` changed from `"0x0000000000000000000000000000000000000000000000000000000000000e10"` to `"0x0000000000000000000000000000000000000000000000000000000000000000"`
    *   Slot `0x000000000000000000000000000000000000000000000000000000000000000a` changed from `"0x0000000000000000000000000000000000000000000000000000000000000000"` to `"0x0000000000000300000000000001518000000000000000400000000000001680"`
    *   Slot `0x000000000000000000000000000000000000000000000000000000000000000b` changed from `"0x0000000000000000000000000000000000000000000000000000000000000000"` to `"0x000000000000000000000000d0fda6925f502a3a94986dfe7c92fe19ebbd679b"`
    *   Slot `0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc` changed from `"0x000000000000000000000000d03bfe2ce83632f4e618a97299cc91b1335bb2d9"` to `"0x00000000000000000000000031da64d19cd31a19cd09f4070366fe2144792cf7"`

@gzeoneth gzeoneth mentioned this pull request Feb 13, 2024
Merged
@gzeoneth gzeoneth marked this pull request as draft February 15, 2024 04:58
@gzeoneth
Copy link
Collaborator Author

Let's wait for upstream to merge Uniswap#126

@gzeoneth
Copy link
Collaborator Author

I synced upstream without knowing it would not prompt me to create a pull request lol
bfdf8f2

@gzeoneth gzeoneth closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DZGoldman DZGoldman Awaiting requested review from DZGoldman

@fredlacs fredlacs Awaiting requested review from fredlacs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gzeoneth