Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings for s6603 #2252

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix warnings for s6603 #2252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/Polly.Specs/RateLimit/RateLimitPolicySpecsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,7 @@ public void Given_immediate_parallel_contention_ratelimiter_still_only_permits_o

// Act - release gate.
gate.Set();
#pragma warning disable S6603
Within(TimeSpan.FromSeconds(10 /* high to allow for slow-running on time-slicing CI servers */), () => tasks.All(t => t.IsCompleted).Should().BeTrue());
#pragma warning restore S6603
Within(TimeSpan.FromSeconds(10 /* high to allow for slow-running on time-slicing CI servers */), () => tasks.ToList().TrueForAll(t => t.IsCompleted).Should().BeTrue());

// Assert - one should have permitted execution, n-1 not.
var results = tasks.Select(t => t.Result).ToList();
Expand Down
4 changes: 1 addition & 3 deletions test/Polly.Specs/RateLimit/TokenBucketRateLimiterTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,7 @@ public void Given_immediate_parallel_contention_ratelimiter_still_only_permits_o

// Act - release gate.
gate.Set();
#pragma warning disable S6603
Within(TimeSpan.FromSeconds(10 /* high to allow for slow-running on time-slicing CI servers */), () => tasks.All(t => t.IsCompleted).Should().BeTrue());
#pragma warning restore S6603
Within(TimeSpan.FromSeconds(10 /* high to allow for slow-running on time-slicing CI servers */), () => tasks.ToList().TrueForAll(t => t.IsCompleted).Should().BeTrue());

// Assert - one should have permitted execution, n-1 not.
var results = tasks.Select(t => t.Result).ToList();
Expand Down